37694 - The bookmarks menu is drawing badly. Submenus should align text top with their parent's item

Status: NEW

(Core :: XUL, defect, P3)

Description

[timeless]

BuildID:    2000043015

See picture. I think that submenus for menu item 0 of a menu draws one pixel 
lower than other submenus.  There are also other rules like the bottom edge of 
the top item [when selected] on a submenu [not 0] is a pixel lower than the 
selected parent.

Reproducible: Always
Steps to Reproduce:
click bookmarks, mouse over various menu items w/ children [0th items behave 
differently from other items -- as parents]

Actual Results:  Cascading a single pixel down

Expected Results:  no drop as menus cascade.  Each line of text should have the 
same baseline as it's parent and child.

Comment 1

[timeless]

Attachment: Menus misaligned [as described in bug]

Comment 2

[Mike Pinkerton (not reading bugmail)]

cosmetic

Comment 3

[:deanis74]

Is this specific to Windows or is it xp?

Comment 4

[Peter Trudelle]

Mass-moving all M20-M30 XPToolkit bugs to Future

Comment 5

[timeless]

Dean: I think this is XP.
German: do we like this 'feature'?
Hyatt: could we fix this?

Comment 6

[David Hyatt]

I think this has long since been fixed.  The screenshot is of the blue skin, 
which is obsolete.

Comment 7

[timeless]

This still happens in modern2 and classic [9/26-8], but this windows nt box
doesn't have paint [or any app that can save images]...

Comment 8

[:deanis74]

Attachment: Screenshot attached. Anyone know the function, off the top of their head, that positions submenus?

Comment 9

[Mike Pinkerton (not reading bugmail)]

Dean, the routine that positions everything is in

http://lxr.mozilla.org/seamonkey/source/layout/xul/base/src/nsMenuPopupFrame.cpp#477

in SyncViewWithFrame(). Patches would be welcome. I will go on record saying
that I'm never going to waste my time to fix this ;)

Comment 10

[timeless]

Updating summary. w/ newer skins it becomes very clear I want text tops to line 
up.

Thank you pinkerton, only 292 lines, this should be pretty easy :-)

Comment 11

[:deanis74]

Suggested Fix: if the submenu is opened by the first frame in its parent, align 
the submenu with the top of the popup frame instead of the menu frame.

Comment 12

[timeless]

Dean: the problem is now consistent, it doesn't matter if the parent is item 0, 
1 or 20.  Is it possible to ask the popup window to orient based on a child 
instead of its top left corner. Hrm

What if..
the popup menu is created (somewhere), we ask its first child for it's top 
coord, and use that to get a delta (relative to the popup menu top).  In 
reality, this delta should not change unless the skin is changed.  Then we can 
just subtract this from the popup whenever we create it.

On skin change this is discarded, and regenerated.

Comment 13

[:deanis74]

Or just try and align the top of the text of the first menu frame within the 
popup menu with the given co-ordinates, instead of aligning the popup frame.

Comment 14

[timeless]

*** Bug 29069 has been marked as a duplicate of this bug. ***

Comment 15

[:deanis74]

There's another good screenshot in bug 29069.

Comment 16

[John Morrison]

*** Bug 74580 has been marked as a duplicate of this bug. ***

Comment 17

[:deanis74]

*** Bug 97077 has been marked as a duplicate of this bug. ***

Comment 18

[Bryan]

Confirming in latest trunk nightlies!

BUILD: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050614
Firefox/1.0+ ID:2005061405

Here is a current screenshot from the above build:
http://img21.echo.cx/my.php?image=unalignedmenus3cl.jpg

Bookmark dropdown menus also exhibit this bug.  A fix for this would improve the
look and feel of FF greatly in terms of OS integration.

Comment 19

[Bryan]

If I remember correctly this issue can be fixed by the patch in bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=253661

Comment 20

[Wayne Mery (:wsmwk)]

yes bug 253661 does address some of the issues

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S4. However, the bug has 3 duplicates.
:enndeakin, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 22

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.