377178 - "Go > Mail Start Page" just hide mail headers

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Thomas Schwecherl]

Clicking "Go > Mail Start Page" don't show the Mail Start Page in the message pane. It only hides the mail header of the actual mail in the message pane.

Tested during the last few days with various builds and with new, clean profiles.
I don't touch the preferences as in example in bug #158333.

Reproducable in (English and German)
Thunderbird version 2.0pre (20070327)
Thunderbird version 2.0.0.0pre (20070409)
Thunderbird version 2.0.0.0pre (20070410)
Thunderbird version 3.0a1 (20070410)

Comment 1

[Jonathan Pritchard]

Works for me, Windows XP SP2, Thunderbird 2.0(en-gb) clean install.

Comment 2

[Rod Whiteley]

This happens when Thunderbird is offline, even if your start page is a file, about or chrome URL that is available offline.

Comment 3

[Jonathan Pritchard]

So do we need to cache the mail start page and point to that if offline?

Comment 4

[Rod Whiteley]

No. The point is that offline is irrelevant, because some people's start pages are local resources. What's needed is a fallback when the start page cannot be loaded for any reason at all--perhaps the existing start.xhtml?

Comment 5

[Scott MacGregor]

we're supposed to be loading about:blank when the user is offline.

Comment 6

[Scott MacGregor]

Attachment: a fix

I intended to write this way originally, I'm not sure what happened. If we are offline, load about:blank.

Comment 7

[Phil Ringnalda (:philor)]

Comment on attachment 262957 [details] [diff] [review]
a fix

r=philringnalda

>     dump("Error loading start page.\n");

We probably need a bug on converting dump()s to reportError()s, even though I know and fear who should be the assignee.

Comment 8

[Scott MacGregor]

fixed on the trunk

Comment 9

[Scott MacGregor]

Comment on attachment 262957 [details] [diff] [review]
a fix

Thunderbird only change, no risk to Firefox. Fixes a regression for 1.5.0.x with the new online start page.

If we are offline, load about:blank into the start page. This fixes a problem where loading the start page when in offline mode, causes the header bar to get removed, but the message body still hangs around.

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 262957 [details] [diff] [review]
a fix

approved for 1.8.1.4, a=dveditz for release-drivers if you land today

Comment 11

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.4 using Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.8.1.4pre) Gecko/20070508 Thunderbird/2.0.0.4pre ID:2007050803 and Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.8.1.4pre) Gecko/20070507 Thunderbird/2.0.0.4pre ID:2007050703 - Go -> Mail Start Page loads in offline mode about:blank. Adding verified keyword