377181 - "Jump to here" preference isn't followed by non-native scrollbars

Status: RESOLVED FIXED

(Core :: XUL, defect, P4)

Description

[Asaf Romano (gone)]

The "Click in scrollbar to: Jump to here" preference is not followed by non-native scrollbars. We should fix this now that native scrollbars are gone.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

Note that nsXPLookAndFeel has some caching support so this is not as live as you might have thought.

Comment 3

[Colin Barrett [:cbarrett]]

Comment on attachment 261286 [details] [diff] [review]
patch

>+  { "ui.scrollToClick",
>+    eMetric_AlertNotificationOrigin, PR_FALSE, nsLookAndFeelTypeInt, 0 },

Shouldn't that be:

>+  { "ui.scrollToClick",
>+    eMetric_ScrollToClick, PR_FALSE, nsLookAndFeelTypeInt, 0 },

? Otherwise, looks good.

Comment 4

[Asaf Romano (gone)]

*Oops*, yeah, thanks.

Comment 5

[Asaf Romano (gone)]

Attachment: for checkin

Comment 6

[Asaf Romano (gone)]

mozilla/widget/public/nsILookAndFeel.h 1.60
mozilla/widget/src/cocoa/nsLookAndFeel.mm 1.9
mozilla/widget/src/xpwidgets/nsXPLookAndFeel.cpp 1.53
mozilla/layout/xul/base/src/nsSliderFrame.cpp 1.161
mozilla/modules/libpref/src/init/all.js 3.669

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Reopening per the dupe.

I can confirm in both my CmTrunk build from last night and GPA4 (from 27 Apr, which should have this patch) that this is still broken.

Comment 9

[Asaf Romano (gone)]

STR? Note you have to restart Fx/Cm to get it to read the updated system pref.

Comment 10

[Paul Borokhov (lensovet)]

yes. the system pref had always been that anyway. changing it to "jump one page" then changing it back to "jump to here" (with camino not even open during the process) results in no effect.
...or am i missing something?

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(Actually, native scrollbars didn't require a restart between changes, but that's irrelevant.)

STR: 
1. Switch to "Scroll to here"
2. Launch CmTunk/Minefield/GPA4
3. Load a long page, like http://www.caminobrowser.org/releases/1.0-complete.php
4. Click near the bottom of the scroll well

Expected: Scroll to the bottom of the page
Actual: Scroll down one page

I can repro this with fresh profiles created after changing the system pref in both CmTrunk and GranParadiso A4.

Comment 12

[Samuel Sidler (old account; do not CC)]

I can also reproduce using Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a5pre) Gecko/20070508 Minefield/3.0a5pre

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I filed bug 389775 on the fact changes aren't/won't be live.

Comment 16

[Erin 'Folletto' Casali]

When the submitted diff will be live? :)

I don't know how this works exacly, but since I've seen the priority changed from P2 to P4 instead of seeing it checked in, and since I don't know exacly how this works, I'd like to know what's missing to see this fix applied. :)

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The patch was checked in, but apparently, it doesn't work so the bug is still not fixed. We need someone (Asaf?) to debug this and post a new patch. Maybe Michael can figure it out.

Comment 19

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This bug (and bug 389775) is fixed in my trunk build and the Minefield I have on hand:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008021804 Minefield/3.0b4pre

Based on the range in my CmTrunks, it looks like shebs's work in bug 410112 got these working. :)