377193 - Build fails while building gfx/thebes tests

Status: RESOLVED DUPLICATE of bug 374921

(Toolkit Graveyard :: XULRunner, defect)

Description

[Bernhard Rosenkraenzer]

User-Agent:       Mozilla/5.0 (compatible; Konqueror/3.5; en_US) KHTML/3.5.6 (like Gecko)
Build Identifier: MOZILLA_1_9a3_RELEASE

gmake[2]: Entering directory `/usr/src/CVS/Melepo/trunk/mozilla/obj-i686-pc-linux-gnu/gfx/thebes/test'
c++   -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -O2 -Os -fomit-frame-pointer -ffast-math -fweb -fno-exceptions -fno-rtti -fno-check-new -fvisibility=hidden -I../../../dist/include/cairo -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12   -I../../../dist/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2   -o gfxSurfaceRefCountTest gfxSurfaceRefCountTest.o  -lpthread    -L../../../dist/bin -L../../../dist/lib  -L../../../dist/bin -L../../../dist/lib -L../../../dist/bin -Wl,-rpath-link,../../../dist/bin -lxpcom -lxul  -L../../../dist/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl -lthebes -lgtk-x11-2.0 -latk-1.0 -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lfontconfig -lXext -lXrender -lXinerama -lXi -lXrandr -lXcursor -lXfixes -lpango-1.0 -lcairo -lgmodule-2.0 -ldl -lX11 -lgobject-2.0 -lglib-2.0   -L../../../gfx/cairo/cairo/src -lmozcairo -L../../../gfx/cairo/libpixman/src -lmozlibpixman   -lXrender -lfreetype -lfontconfig  -lz   -ldl -lm  -lpangoxft-1.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0   -lXft -lXrender -lfontconfig -lfreetype -lz -lX11   -lX11    
/usr/bin/ld: cannot find -lthebes
collect2: ld returned 1 exit status


Reproducible: Always

Steps to Reproduce:
1. Build xulrunner 1.9a3 with tests enabled

Actual Results:  
barfs

Expected Results:  
compiles

The problem is that the newly built libthebes.a (even though it's there) isn't found, it's a missing -L somewhere in the Makefile.

Also, REQUIRES= in the thebes/tests Makefile.in lists thebes twice.

Comment 2

[Bernhard Rosenkraenzer]

Attachment: Probably not the correct fix, but it works

I don't fully understand how mozilla's Makefile system works, but this fixes it