374921 - link error in gfxSurfaceRefCountTest (thebes.lib)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jan Kuemmel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: Head revision 22 March 2007

using mozillabuild 1.0

Reproducible: Always

Steps to Reproduce:
1. make -f client.mk
2.
3.
Actual Results:  
cl -FogfxSurfaceRefCountTest.obj -c  -DMOZILLA_INTERNAL_API -DOSTYPE=\"WINNT5.1\" -DOSARCH=\"WINNT\" -DBUILD_ID=0000000000  -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/thebes -I../../../dist/include/cairo -I../../../dist/include/pref -I../../../dist/include/thebes -I../../../dist/include   -I../../../dist/include -I../../../dist/include/nspr  -DMOZ_PNG_READ -DPNG_NO_MMX_CODE -DMOZ_PNG_WRITE        -GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -FdgfxSurfaceRefCountTest.pdb  -DNDEBUG -DTRIMMED -O1 -I../../../dist/include/cairo  -MD            -D_CRT_SECURE_NO_DEPRECATE=1 -D_CRT_NONSTDC_NO_DEPRECATE=1 -DWINVER=0x500 -D_WIN32_WINNT=0x500 -D_WIN32_IE=0x0400 -DX_DISPLAY_MISSING=1 -DMOZILLA_VERSION=\"1.9a3pre\" -DMOZILLA_VERSION_U=1.9a3pre -DHAVE_SNPRINTF=1 -D_WINDOWS=1 -D_WIN32=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1 -DD_INO=d_ino -DMOZ_EMBEDDING_LEVEL_DEFAULT=1 -DMOZ_EMBEDDING_LEVEL_BASIC=1 -DMOZ_EMBEDDING_LEVEL_MINIMAL=1 -DMOZ_XULRUNNER=1 -DMOZ_BUILD_APP=xulrunner -DMOZ_XUL_APP=1 -DMOZ_DEFAULT_TOOLKIT=\"cairo-windows\" -DMOZ_THEBES=1 -DMOZ_CAIRO_GFX=1 -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1 -DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_NO_XPCOM_OBSOLETE=1 -DMOZ_XTF=1 -DMOZ_AIRBAG=1 -DMOZ_MATHML=1 -DMOZ_ENABLE_CANVAS=1 -DMOZ_SVG=1 -DMOZ_SVG_FOREIGNOBJECT=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_PLACES=1 -DMOZ_FEEDS=1 -DMOZ_STORAGE=1 -DMOZ_LOGGING=1 -DMOZ_USER_DIR=\"Mozilla\" -DMOZ_ENABLE_LIBXUL=1 -DHAVE_UINT64_T=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_RDF=1 -DMOZ_MORKREADER=1 -DMOZ_DLL_SUFFIX=\".dll\" -DJS_THREADSAFE=1 -DMOZILLA_LOCALE_VERSION=\"1.9a1\" -DMOZILLA_REGION_VERSION=\"1.9a1\" -DMOZILLA_SKIN_VERSION=\"1.8\"  -D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT /c/mozilla-trunk/mozilla/gfx/thebes/test/gfxSurfaceRefCountTest.cpp
gfxSurfaceRefCountTest.cpp
make[6]: *** No rule to make target `../../../dist/lib/thebes.lib', needed by `gfxSurfaceRefCountTest.exe'.  Stop.
make[6]: Leaving directory `/c/mozilla-trunk/mozilla/obj-xulrunner/gfx/thebes/test'
make[5]: *** [tools] Error 2
make[5]: Leaving directory `/c/mozilla-trunk/mozilla/obj-xulrunner/gfx/thebes'
make[4]: *** [tools] Error 2
make[4]: Leaving directory `/c/mozilla-trunk/mozilla/obj-xulrunner/gfx'
make[3]: *** [tools_tier_gecko] Error 2
make[3]: Leaving directory `/c/mozilla-trunk/mozilla/obj-xulrunner'
make[2]: *** [tier_toolkit] Error 2
make[2]: Leaving directory `/c/mozilla-trunk/mozilla/obj-xulrunner'
make[1]: *** [default] Error 2


Expected Results:  
build should complete without errors

luser told me on irc that this is probably due to bug 78081


# my .mozconfig:
. $topsrcdir/xulrunner/config/mozconfig
mk_add_options MOZ_CO_PROJECT=xulrunner
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-xulrunner

ac_add_options --enable-application=xulrunner

Comment 1

[(not currently active) Ted Mielczarek]

FWIW, I hit this on mac too:

c++   -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -isysroot /Developer/SDKs/MacOSX10.4u.sdk -fpascal-strings -no-cpp-precomp -fno-common -fshort-wchar -I/Developer/SDKs/MacOSX10.4u.sdk/Developer/Headers/FlatCarbon -pipe  -DNDEBUG -DTRIMMED -O2 -g -I../../../dist/include/cairo -I/Developer/SDKs/MacOSX10.4u.sdk/Developer/Headers/FlatCarbon -o gfxSurfaceRefCountTest gfxSurfaceRefCountTest.o    -Wl,-dead_strip -L../../../dist/bin -L../../../dist/lib gfxTestCocoaHelper.o -L../../../dist/bin -L../../../dist/lib -L../../../dist/bin -lxpcom -lxpcom_core -L../../../dist/lib -lplds4 -lplc4 -lnspr4 -lthebes -framework Carbon -L../../../modules/zlib/src -lmozz   -framework Cocoa    
/usr/bin/ld: can't locate file for: -lthebes
collect2: ld returned 1 exit status

Comment 2

[Alex Vincent [:WeirdAl]]

I hit this build failure with --enable-tests in my .mozconfig.  I suspect that bug 78081's fix didn't cover that case.  (--disable-tests didn't hit the compile failure.)

Comment 3

[Alex Vincent [:WeirdAl]]

Marking dependency, so others are aware of this issue.

Comment 4

[Benjamin Smedberg]

Attachment: Ifdef tests for libxul, rev. 1

The problem is that thebes is a static library in the libxul configuration, and XPCOM internal symbols are not available. The simple way out avoids building these tests in the libxul configuration.

Comment 5

[Benjamin Smedberg]

This has nothing to do with 78081

Comment 7

[Benjamin Smedberg]

Fixed on trunk.