Closed Bug 377693 Opened 19 years ago Closed 19 years ago

notification.xml cleanup

Categories

(Toolkit :: UI Widgets, defect)

Product:
Toolkit
Component:
UI Widgets
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta1

People

(Reporter: enndeakin, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

fix the test
11.83 KB, patch
asaf
: review+
Details | Diff | Splinter Review
- priority should be an integer - setters should return val
Blocks: 377253
Attached patch cleanup (obsolete) — — Splinter Review
Attached patch add testcase (obsolete) — — Splinter Review
Attachment #261868 - Attachment is obsolete: true
Attachment #262909 - Flags: review?(mano)
Comment on attachment 262909 [details] [diff] [review] add testcase r=mano.
Attachment #262909 - Flags: review?(mano) → review+
Target Milestone: --- → mozilla1.9beta2
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Test seems to crash/hang on Windows so need to investigate further.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
It also failed three of its assertions on one of the linux runs.
Attached patch fix the test — — Splinter Review
Fix the testcase by using the right urls and not chrome urls, and also use the internal _timer property to check when the timer has fired rather than just guessing that 400ms is enough time to wait for the notification to open.
Attachment #262909 - Attachment is obsolete: true
Attachment #276794 - Flags: review?(mano)
Of course, this file needs to be added back to the makefile again as well.
What was/is wrong with using chrome uris?
(In reply to comment #8) > What was/is wrong with using chrome uris? > Mano, this isn't a chrome test, so chrome urls shouldn't be used. On Windows this causes a failure because the chrome tests are currently disabled there.
Comment on attachment 276794 [details] [diff] [review] fix the test ah
Attachment #276794 - Flags: review?(mano) → review+
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: