notification.xml cleanup

RESOLVED FIXED in mozilla1.9beta1

Status

()

Toolkit
XUL Widgets
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Neil Deakin, Assigned: Neil Deakin)

Tracking

(Blocks: 1 bug)

unspecified
mozilla1.9beta1
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

11 years ago
- priority should be an integer
- setters should return val
(Assignee)

Updated

11 years ago
Blocks: 377253
(Assignee)

Comment 1

11 years ago
Created attachment 261868 [details] [diff] [review]
cleanup
(Assignee)

Comment 2

11 years ago
Created attachment 262909 [details] [diff] [review]
add testcase
Attachment #261868 - Attachment is obsolete: true
Attachment #262909 - Flags: review?(mano)
(Assignee)

Updated

11 years ago
Target Milestone: --- → mozilla1.9beta2
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

11 years ago
Test seems to crash/hang on Windows so need to investigate further.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 5

11 years ago
It also failed three of its assertions on one of the linux runs.
(Assignee)

Comment 6

11 years ago
Created attachment 276794 [details] [diff] [review]
fix the test

Fix the testcase by using the right urls and not chrome urls, and also use the internal _timer property to check when the timer has fired rather than just guessing that 400ms is enough time to wait for the notification to open.
Attachment #262909 - Attachment is obsolete: true
Attachment #276794 - Flags: review?(mano)
(Assignee)

Comment 7

11 years ago
Of course, this file needs to be added back to the makefile again as well.
What was/is wrong with using chrome uris?
(Assignee)

Comment 9

11 years ago
(In reply to comment #8)
> What was/is wrong with using chrome uris?
> 

Mano, this isn't a chrome test, so chrome urls shouldn't be used. On Windows this causes a failure because the chrome tests are currently disabled there.

(Assignee)

Updated

11 years ago
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.