Last Comment Bug 377920 - Distinguish between automatic and manual marking as read of junk in preferences
: Distinguish between automatic and manual marking as read of junk in preferences
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: MailNews: Message Display (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Karsten Düsterloh
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-04-18 11:05 PDT by Larry Nelson
Modified: 2007-06-20 16:25 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
show both prefs in preferences panel (4.17 KB, patch)
2007-04-18 15:00 PDT, Karsten Düsterloh
neil: review+
neil: superreview+
kairo: approval‑seamonkey1.1.2-
Details | Diff | Splinter Review
version checked in, incorporating KaiRo's wording (4.80 KB, patch)
2007-06-20 16:25 PDT, Karsten Düsterloh
no flags Details | Diff | Splinter Review

Description Larry Nelson 2007-04-18 11:05:52 PDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.2) Gecko/20070222 SeaMonkey/1.1.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.2) Gecko/20070222 SeaMonkey/1.1.1

If you flag a email as junk "SeaMonkey" will flag it as "read" even if you DID NOT selected the option "Mark messages determined to be junk as read:" [You would select this option ONLY if you WANT to mark junk messages as read]


Reproducible: Always

Steps to Reproduce:
1. Click on edit tab/preferences Mail & Newsgroups/Junk Mail
2. Make sure that "Mark messages determined to be junk as read:" is NOT checked
3. Click on OK
4. Mark an email as junk 
Actual Results:  
Mark an email as junk and you will find the email in your Junk folder mark incorrectly as read.

Expected Results:  
If the option "Mark messages determined to be junk as read" is turn off, and an email is flagged as junk, it should be put into the junk folder marked as unread.
Comment 1 Karsten Düsterloh 2007-04-18 13:39:28 PDT
This option "Mark messages determined to be junk as read" (see mail.spam.markAsReadOnSpam in about:config) controls only the behaviour of mails marked as junk by the *automatic* junk filter.
To turn off the marking as read when *manually* setting the junk status, set the pref mailnews.ui.junk.manualMarkAsJunkMarksRead to false.

I confirm, though, that this distinction is quite invisible, so let me morph this bug in a request to change this... ;-)
Comment 2 Larry Nelson 2007-04-18 14:11:09 PDT
(In reply to comment #1)
> This option "Mark messages determined to be junk as read" (see
> mail.spam.markAsReadOnSpam in about:config) controls only the behaviour of
> mails marked as junk by the *automatic* junk filter.
> To turn off the marking as read when *manually* setting the junk status, set
> the pref mailnews.ui.junk.manualMarkAsJunkMarksRead to false.
> 
> I confirm, though, that this distinction is quite invisible, so let me morph
> this bug in a request to change this... ;-)
> 

Karsten,

Thank you for the information, that worked! Yes please put in a request to change this.

-Larry-

Comment 3 Karsten Düsterloh 2007-04-18 15:00:57 PDT
Created attachment 262039 [details] [diff] [review]
show both prefs in preferences panel

The patch is against trunk, but the only difference to branch is the location of pref-junk.dtd.
Comment 4 Robert Kaiser 2007-04-18 15:21:09 PDT
Comment on attachment 262039 [details] [diff] [review]
show both prefs in preferences panel

We can't take locale changes on branch. Sorry.
Comment 5 neil@parkwaycc.co.uk 2007-04-19 07:32:44 PDT
Comment on attachment 262039 [details] [diff] [review]
show both prefs in preferences panel

I'm not convinced the wording, or indeed the grouping, makes sense.

P.S. your patch is corrupt, it's missing mailnews/ and suite/
Comment 6 neil@parkwaycc.co.uk 2007-04-19 07:34:37 PDT
How about:
Mark junk messages as read:
[ ] When the junk filter determines that they are junk
[X] When I mark them as junk
Comment 7 Larry Nelson 2007-04-19 08:18:40 PDT
(In reply to comment #6)
> How about:
> Mark junk messages as read:
> [ ] When the junk filter determines that they are junk
> [X] When I mark them as junk
> 

Yes, That is what I was hoping for.

Comment 8 Robert Kaiser 2007-04-19 10:09:14 PDT
(In reply to comment #6)
> How about:
> Mark junk messages as read:
> [ ] When the junk filter determines that they are junk
> [X] When I mark them as junk

Hmm, the first point is too much "junk" for me, and the second option is IMHO not clearly enough different from the first one.

My proposal:

Mark messages as read:
[ ] When SeaMonkey* determines that they are junk
[X] When I manually mark them as junk

(*: use &brandShortName; there)
Comment 9 Larry Nelson 2007-04-19 10:41:40 PDT
(In reply to comment #8)
> (In reply to comment #6)
> Mark messages as read:
> [ ] When SeaMonkey* determines that they are junk
> [X] When I manually mark them as junk
> (*: use &brandShortName; there)

This Idea is also good.
Comment 10 Tom Conder 2007-04-25 13:03:43 PDT
It eludes me why anyone would want messages to be marked as read when they are manually marked as junk. But, I like the idea of a dialog that gives: 

[ ] Mark message as read when I mark it as junk (off by default!)

Then how about adding a setting to the JUNK FILTER dialog to mark messages as read when the filter marks them as read?

[X] Mark message as read when filter marks it as junk

Comment 11 neil@parkwaycc.co.uk 2007-04-25 13:13:53 PDT
Comment on attachment 262039 [details] [diff] [review]
show both prefs in preferences panel

sr=me with KaiRo's wording.
Comment 12 Karsten Düsterloh 2007-06-20 16:24:32 PDT
Landed on trunk.
Comment 13 Karsten Düsterloh 2007-06-20 16:25:19 PDT
Created attachment 269138 [details] [diff] [review]
version checked in, incorporating KaiRo's wording

Note You need to log in before you can comment on or make changes to this bug.