Closed
Bug 377934
Opened 18 years ago
Closed 18 years ago
Audit default bookmarks set
Categories
(Camino Graveyard :: Bookmarks, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.6
People
(Reporter: froodian, Assigned: samuel.sidler+old)
Details
(Keywords: fixed1.8.1.12)
Attachments
(1 file, 6 obsolete files)
|
14.72 KB,
text/plain
|
Details |
We should give the default bookmarks an overhaul before the 1.6 release - some of them are old and crufty, and others don't pander to our target audience.
Comment 1•18 years ago
|
||
(In reply to comment #0)
> We should give the default bookmarks an overhaul before the 1.6 release - some
> of them are old and crufty, and others don't pander to our target audience.
Yeah, those damn leftist commie news sites need a serious overhaul. ;)
Were there specific sites you were thinking needed to go, or specific ones that we should add?
smorgan wanted to axe the web standards stuff, iirc.
Comment 3•18 years ago
|
||
Yeah. "We're not a browser for developers, but we think you probably want to read W3C specs"
Comment 4•18 years ago
|
||
Sounds reasonable.
Were there any others that needed to go? I'd make an argument that MacNN is a good candidate for deletion, as is MacCentral (why not just have a bookmark to MacWorld?).
Might I suggest we also remove the Camino Feedback bookmark and include a bookmark to our support forums in its place (though not necessarily in the same place in the bookmarks file)?
Comment 5•18 years ago
|
||
pimpmycamino.com should be there if it's not.
OSXFAQ hasn't been updated since early 2006, and Mac OS X Apps since early 2005 (both are stuck in 10.1/10.2 Aqua :P )
I'd like to maintain some sort of user-friendly standards-type page somewhere in our bookmarks, but the current ones clearly are not suitable ;)
| Assignee | ||
Comment 7•18 years ago
|
||
I'm working on a new set. I'll post it here. Someone else can do whatever work is required after we agree on a new set.
Assignee: nobody → samuel.sidler
Comment 8•18 years ago
|
||
I was just about to file this, but was crafty enough to search Bugzilla first. There are very few things in the current set that I think should stay.
Flags: camino1.6?
| Assignee | ||
Comment 9•18 years ago
|
||
This is the current default bookmark list.
A ">" denotes a folder and a ">>" denotes a tab group.
| Assignee | ||
Comment 10•18 years ago
|
||
Here's my purposed new list. This list isn't really complete because the "webstandards.org" link is lame, but I can't find a better one.
Philippe, can you think of a better site to send end-users to about web standards?
Notes about the Bookmarks menu:
* Apple Stuff -> Apple Sites
* I merged Mac News and Mac Support together. Having four folders for
Mac/Apple-related topics seemed too many.
* I removed macnn.com, macsurfer.com, and osxfaq.com
* I added tuaw.com to the Mac News & Support folder
* In "Mac Software", I removed both versiontracker and macosxapps.com and
replaced them with opensourcemac.org and osx.iusethis.com
* I moved the Tech News folder to the bookmark bar (but this would be fine to
move back to the Bookmarks Menu)
* I removed the Web Standards folder as well as the dmoz.org bookmark
* I added a "Shopping" folder with amazon.com, buy.com, ebay.com, and
pricegrabber.com
* I added a "Social" folder with facebook.com, flickr.com, linkedin.com,
livejournal.com, myspace.com, and wordpress.com
* yahoo.com remains and google.com and webstandards.org have been added.
Before I get into the Bookmark Bar, some rationale:
* The web is very much used for shopping. It seems reasonable to link to some
of the popular web shopping destinations.
* Likewise, the web is more and more being used for social networking sites
as well as blogging sites. Adding the more popular of those seems
reasonable. I doubt a single one of our users does not use at least one of
those sites.
Notes about the Bookmark Bar:
* I updated the Camino Info folder to link to the home page, the help page,
and pimpmycamino.com and left the mozilla.org bookmark. Part of me thinks
we should link to /contribute too. Volunteers are always good. :)
* The News folder now removes cnn.com and iht.com because they both have
pop-ups. It adds msnbc.com, guardian.co.uk, and the Google and Yahoo news
sites. I kind of want to add nytimes.com as well, but am unsure. Comments?
* I've renamed removed the "Mac News" tab group
* I moved in the "Tech News" folder, which now has the following links:
news.com, wired.com, macworld.com, news.zdnet.com
* Google.com remains on the Bookmark Bar, however I also added Amazon.com
Rationale for the Bookmark Bar:
* Removing the feedback link is a Good Thing since most users just want help.
Adding the Help link solves this.
* Linking to pimpmycamino.com seems good to me since a number of our users
are looking for add-ons to the browser to meet their needs.
* The News links needed an update. We don't want sites in there by default
which have pop-ups since that hurts the user-experience. msnbc.com seems
like a logical choice to replace cnn.com since its redesign and popularity
(search for "news" in Google).
* The addition of guardian.co.uk is to balance out the loss of iht.com and
add another international news outlet.
* Adding both Google and Yahoo News adds a more "immediate" news source and
lets the user customize their news if they have accounts on either.
* I'm still unsure about nytimes.com... I could go either way.
* The removal of a tab group on the Bookmark bar seems smart to me given the
number of users who previously complained about losing their current tabs.
I'm okay with going either way on this. What does everyone else thing?
* Moving Tech News front and center seems smart because most of our users will
want an overall look and not necessarily an all-Mac look. That said,
macworld.com seems to fit in here and adding a fourth site seemed good as
well.
* My shopping explanation is above. It's true here as well and amazon.com is
the leader overall.
* I *wanted* to add search.yahoo.com to the main bookmark bar (probably in
lieu of amazon.com), but given the problems Yahoo has with supporting
Camino, I couldn't justify it. Having two search providers seems good
though. Any suggestions?
So... rough me up. Some of these changes I'm sure people won't like, but let me know what you think and what should/shouldn't change.
| Assignee | ||
Comment 11•18 years ago
|
||
And I realized(In reply to comment #10)
> * yahoo.com remains and google.com and webstandards.org have been added.
I realized I didn't actually add "google.com". I'll add it in the next round after feedback.
Comment 12•18 years ago
|
||
Is there a reason that VersionTracker, as heinous as it is, was removed from the "Mac Software" folder? I don't think either of the sites that were added are really anywhere near "replacements" for VersionTracker (which I would keep) or MacUpdate (which I would add). There are a lot of things not to like about both those sites but the bottom line is that they're really *the* Mac software sites and anything else is a pretty poor substitute.
I'd be very much in favour of adding the NYT to News.
I'd toss Pricegrabber and put Froogle (or whatever Google is calling it these days) in its place. I know we have a lot of Google properties in there already, but again, Froogle really *is* one of the best, if not *the* best, price comparison search out there.
I'm not sure we really need news.zdnet.com since we have Macworld (also a Ziff-Davis property) and CNet pretty much covers all the same material.
That's all I've got for now.
| Assignee | ||
Comment 13•18 years ago
|
||
Oh, and I also wanted to add Wikipedia to the main Bookmarks menu.
I'll address comments later, when they all come.
Comment 14•18 years ago
|
||
(In reply to comment #13)
> Oh, and I also wanted to add Wikipedia to the main Bookmarks menu.
I meant to say something about that, too. It's sort of conspicuous by its absence right now, and I also think we should add it.
Comment 15•18 years ago
|
||
I would drop webstandards.org. Both the site and the organisation have far outlived their usefulness, in my book (acid2 test aside, which I actually love, but not for the usual/popular reasons). Is a bookmark to 'something about webstandards' really needed ? The average user doesn't care (or doesn't really understand), the advanced user who cares or need-to-know will easily find the info via her favourite search engine.
---
On the other hand, + 1 on
Wikipedia
MacUpdate.com
Not convinced the NYT is really needed.
I would put search.yahoo.com on the BM bar (google is already the default in the search box).
First off, the list "seems" a lot longer now (I guess because I tended to ignore some of the dead stuff), though math shows it's really not that much different. But we do want to be careful about filling our users' default bookarks with stuff they just want to delete.
* Second, I think we can completely axe the "Apple Sites" folder. We already
link to Apple Support and Apple Downloads elsewhere; I see no reason we need
to link directly to apple.com (and apple.com/macosx seems kind of superfluous
to me).
* I have three issues with Mac.com, in no particular order:
1) people will complain we're "promoting" a pay service,
2) we don't integrate with dotMac at all, and
3) dotMac properties are awful about either blocking or completely failing to
work with Camino (but working fine with Fx), so it's a bad UX.
* Macfixit is a vacuous shell of its former self, built on promoting hacks and
then hyping bad things that happen when you do hacks.
* I absolutely take exception with adding sites that are complete a**es to us.
I know MU is prettier and by and large users like MU better, but sites that
hassle us, link the wrong place, link old binaries, etc., aren't worthy of
our "endorsement." If the others aren't "good enough," then VT or nothing.
* I'm kinda "meh" on the Social stuff, both having the category and its current
name. That's not really my area of expertise, though. We should come up
with a better name, though.
* NYTimes: yes, please (though I'm not stuck on it, but it does seem an odd
omission to me).
* Tech News:
1) I second the removal of news.zdnet
2) I don't think Tech News should be on the Bar. You and I might be
interested in Tech News, but Ian's mom is not. My guess mento's mom is
not, either, but then again, she is mento's mom, so you never know ;)
Point is, most of our users aren't really technical. Mac News is more
appropriate for the Bar, but probably not by much.
> * I *wanted* to add search.yahoo.com to the main bookmark bar (probably in
> lieu of amazon.com), but given the problems Yahoo has with supporting
> Camino, I couldn't justify it. Having two search providers seems good
> though. Any suggestions?
I agree with this. No suggestion, though, given the repeated problems we have with Yahoo.
I also think we should have a tab group somewhere; it's the only way we demo this feature. "Recently Closed Tabs" should make it suck less.
I wish there were a user-focused standards-type site out there, but if philippe can't come up with one and doesn't like WaSP, then let's axe that.
| Assignee | ||
Comment 17•18 years ago
|
||
From IRC today, Ian's comments:
* s/Social/Social Networks? Or Communities?
* Better name is more important than alpha placing
* "switch tech news with shopping", "it's a good addition", "it's probably
the group my mom will use most"
* Pricegrabber is okay (My note: Froogle/Google Products is less visible
lately.)
* "should we have craigslist somewhere?" <-- Maybe. Shopping?
* "should we have maps.g.com or mapquest somewhere?" <-- Yes. Google Maps.
* "i agree we just kill webstandards, btw. it's a valiant thought, but our
target userbase shouldn't know the difference, and anybody else either
knows already, or isn't going to be learning from us"
| Assignee | ||
Comment 18•18 years ago
|
||
Oh, one more thing (which I agree with):
02:16 < sauron> what is our goal with these bookmarks?
02:17 < froodian> to provide a base set of bookmarks which the most casual user could use as a window into the internet
Comment 19•18 years ago
|
||
I don't really care for the "social" category, and especially how it supports the stalking industry, but it seems that if it's to be in the default set, it should include some video site.
Most of my other opinions on the proposed list have already been raised by others' comments.
Comment 20•18 years ago
|
||
I'd axe the social category (or at least parts of it) due to several of the sites there needing accounts to do anything useful at. Facebook and LinkedIn aren't really casual-browsing sort of sites, for example; either you've joined and you know where it is, or you haven't and going there isn't very useful.
From a practical standpoint: myspace is the source of many of the absolute worst-performance pages for Camino on the entire internet, to the degree that people with older machines sometimes have to force quit. Pointing people there (pre 2.0 at least) seems iffy.
Do these get localized? If so, 1) this should block b2 and 2) we need a "policy" about localization.
Flags: camino1.6b2?
| Assignee | ||
Comment 22•18 years ago
|
||
(In reply to comment #12)
> Is there a reason that VersionTracker, as heinous as it is, was removed from
> the "Mac Software" folder? I don't think either of the sites that were added
> are really anywhere near "replacements" for VersionTracker (which I would keep)
> or MacUpdate (which I would add). There are a lot of things not to like about
> both those sites but the bottom line is that they're really *the* Mac software
> sites and anything else is a pretty poor substitute.
For the reasons Smokey gave. Supporting sites that are horrible to us on a number of accounts doesn't end up helping our users. That said, VT is the lesser of the two evils and I'll re-add it.
> I'd be very much in favour of adding the NYT to News.
Added.
> I'd toss Pricegrabber and put Froogle (or whatever Google is calling it these
> days) in its place. I know we have a lot of Google properties in there already,
> but again, Froogle really *is* one of the best, if not *the* best, price
> comparison search out there.
Froogle, now Google Products, has seen a lower drop in traffic as well as less support. I'd rather support a product that we know will stick around and has been around a while. Pricegrabber is in the business of this, Google's just doing it part time. I'd trust them to provide better support to our users.
> I'm not sure we really need news.zdnet.com since we have Macworld (also a
> Ziff-Davis property) and CNet pretty much covers all the same material.
Removed.
(In reply to comment #15)
> I would drop webstandards.org. Both the site and the organisation have far
> outlived their usefulness, in my book (acid2 test aside, which I actually love,
> but not for the usual/popular reasons). Is a bookmark to 'something about
> webstandards' really needed ? The average user doesn't care (or doesn't really
> understand), the advanced user who cares or need-to-know will easily find the
> info via her favourite search engine.
Removed.
> On the other hand, + 1 on
> Wikipedia
Added.
> MacUpdate.com
Using VT instead of MU.
> Not convinced the NYT is really needed.
I've added this since most people seem to agree with it. If more people disagree, however, it's the first to go.
> I would put search.yahoo.com on the BM bar (google is already the default in
> the search box).
For the reasons I gave, and the reasons Smokey gave, I'm hesitant to do this. See also that bug you just filed about Yahoo and non-Firefox 2.0 browsers. ;)
(In reply to comment #16)
> First off, the list "seems" a lot longer now (I guess because I tended to
> ignore some of the dead stuff), though math shows it's really not that much
> different. But we do want to be careful about filling our users' default
> bookarks with stuff they just want to delete.
The next version of this list will feel leaner. :)
> * Second, I think we can completely axe the "Apple Sites" folder. We already
> link to Apple Support and Apple Downloads elsewhere; I see no reason we need
> to link directly to apple.com (and apple.com/macosx seems kind of superfluous
> to me).
>
> * I have three issues with Mac.com, in no particular order:
> 1) people will complain we're "promoting" a pay service,
> 2) we don't integrate with dotMac at all, and
> 3) dotMac properties are awful about either blocking or completely failing to
> work with Camino (but working fine with Fx), so it's a bad UX.
All removed.
> * Macfixit is a vacuous shell of its former self, built on promoting hacks and
> then hyping bad things that happen when you do hacks.
Removed.
> * I absolutely take exception with adding sites that are complete a**es to us.
> I know MU is prettier and by and large users like MU better, but sites that
> hassle us, link the wrong place, link old binaries, etc., aren't worthy of
> our "endorsement." If the others aren't "good enough," then VT or nothing.
VT added instead of MU for the reasons here (and other issues in the past).
> * I'm kinda "meh" on the Social stuff, both having the category and its current
> name. That's not really my area of expertise, though. We should come up
> with a better name, though.
Still not sure what name is better, but changes were made to this folder. See below.
> * NYTimes: yes, please (though I'm not stuck on it, but it does seem an odd
> omission to me).
Added.
> * Tech News:
> 1) I second the removal of news.zdnet
Removed.
> 2) I don't think Tech News should be on the Bar. You and I might be
> interested in Tech News, but Ian's mom is not. My guess mento's mom is
> not, either, but then again, she is mento's mom, so you never know ;)
> Point is, most of our users aren't really technical. Mac News is more
> appropriate for the Bar, but probably not by much.
Tech News has been moved to the menu.
> > * I *wanted* to add search.yahoo.com to the main bookmark bar (probably in
> > lieu of amazon.com), but given the problems Yahoo has with supporting
> > Camino, I couldn't justify it. Having two search providers seems good
> > though. Any suggestions?
>
> I agree with this. No suggestion, though, given the repeated problems we have
> with Yahoo.
I can't think of anything better yet, so we're going to leave it how it is.
> I also think we should have a tab group somewhere; it's the only way we demo
> this feature. "Recently Closed Tabs" should make it suck less.
I'd be in favor of this, but I'm still not sure which one would make a good group. Ideally, it'd have to be small (four bookmarks or less) and targeted. How do you feel about making Tech News (in the menu) a tab group?
> I wish there were a user-focused standards-type site out there, but if philippe
> can't come up with one and doesn't like WaSP, then let's axe that.
Removed.
(In reply to comment #17)
> From IRC today, Ian's comments:
> * s/Social/Social Networks? Or Communities?
> * Better name is more important than alpha placing
I'm still not sure. I don't like Social Networks for sure. Communities... maybe. I think Social still fits better.
> * "switch tech news with shopping", "it's a good addition", "it's probably
> the group my mom will use most"
I don't want to overwhelm the bookmark bar and I think removing Tech News from it was a good option. Adding Shopping seems like it'd be too much (even if we remove Amazon). Three folders did feel a bit heavy.
> * Pricegrabber is okay (My note: Froogle/Google Products is less visible
> lately.)
Kept.
> * "should we have craigslist somewhere?" <-- Maybe. Shopping?
Added to Shopping. More of Ian's arguments on this, which I semi-disagreed with but agree with now... People who visit Craigslist from their browser are probably more likely to be shopping than submitting links; whether shopping for goods, services, jobs, apartments, etc. It fits in that folder more than any other and makes sense here for the bulk of our userbase.
> * "should we have maps.g.com or mapquest somewhere?" <-- Yes. Google Maps.
Added to the main menu.
> * "i agree we just kill webstandards, btw. it's a valiant thought, but our
> target userbase shouldn't know the difference, and anybody else either
> knows already, or isn't going to be learning from us"
Removed.
(In reply to comment #19)
> I don't really care for the "social" category, and especially how it supports
> the stalking industry, but it seems that if it's to be in the default set, it
> should include some video site.
YouTube added.
(In reply to comment #20)
> I'd axe the social category (or at least parts of it) due to several of the
> sites there needing accounts to do anything useful at. Facebook and LinkedIn
> aren't really casual-browsing sort of sites, for example; either you've joined
> and you know where it is, or you haven't and going there isn't very useful.
These are good points that I didn't think of. I removed Facebook and LinkedIn but kept Flickr, LJ, and Wordpress.
> From a practical standpoint: myspace is the source of many of the absolute
> worst-performance pages for Camino on the entire internet, to the degree that
> people with older machines sometimes have to force quit. Pointing people there
> (pre 2.0 at least) seems iffy.
Removed. I also added YouTube to this folder.
| Assignee | ||
Comment 23•18 years ago
|
||
(In reply to comment #21)
> Do these get localized? If so, 1) this should block b2 and 2) we need a
> "policy" about localization.
I think some localizers do. I wouldn't be opposed to all/most localizing the Googles, Yahoos, and news sites, but we would definitely need to work on a policy for this and probably enforce it.
| Assignee | ||
Comment 24•18 years ago
|
||
Taking in the comments above, here's the new proposed list. In case you don't want to read that huge comment, here's a list of changes:
* Removed Apple Sites
* Removed macfixit.com
* Added VersionTracker to Mac Software
* Added Craigslist to Shopping
* Removed Facebook, LinkedIn, and MySpace from Social
* Added YouTube to Social
* Moved Tech News to the menu from the bar
* Removed ZDNet from Tech News
* *Really* added Google to the menu (uncategorized)
* Added Wikipedia (en; this could be localized or we could remove the end
here) and Google Maps to the menu (uncategorized)
* Added NYTimes to News in the bar
Still to do, possibly:
* Rename Social to... ?
* Make Tech News a tab group?
Feedback on those two things would be great.
Attachment #295047 -
Attachment is obsolete: true
| Assignee | ||
Comment 25•18 years ago
|
||
Also, CCing Simon and Mike. If either of you have opinions on these new proposed defaults, please comment here (or email me).
> Still to do, possibly:
> * Rename Social to... ?
Perhaps something related to "Life" or "Fun" ?
> * Make Tech News a tab group?
That's a good one to use, yes.
Comment 27•18 years ago
|
||
(In reply to comment #22)
> (In reply to comment #15)
[...]
>
> Removed.
> > I would put search.yahoo.com on the BM bar (google is already the default in
> > the search box).
>
> For the reasons I gave, and the reasons Smokey gave, I'm hesitant to do this.
> See also that bug you just filed about Yahoo and non-Firefox 2.0 browsers. ;)
I was suggesting the subdomain 'search.yahoo.com' specifically, which doesn't do browser detection (at least not the U.S. one, nor the Japanese one, can't say about any other country specific subdomain).
| Assignee | ||
Comment 28•18 years ago
|
||
(In reply to comment #27)
> I was suggesting the subdomain 'search.yahoo.com' specifically, which doesn't
> do browser detection (at least not the U.S. one, nor the Japanese one, can't
> say about any other country specific subdomain).
My problem isn't really with that site itself, but with the results site which calls http://us.js2.yimg.com/us.js.yimg.com/lib/s3/ysch_srp_clean_assist_200712141535.js which *does* have browser detection in it. Though, right now, it rightly looks for Gecko (afaict), there's no guarantee that they won't mess it up, as they have in the past with other sites.
Comment 29•18 years ago
|
||
after some chatter on irc, i'm cool with this list.
Any particular reason this and Credits.rtf live in application/localized/English.lproj instead of resources/localized/English.lproj with all of our other localizable resources?
| Assignee | ||
Comment 31•18 years ago
|
||
Here's the final plist. This is not a patch. A couple of notes:
* I went ahead and made Tech News a tab group.
* I stuck with "Social" as the name of the folder since we haven't thought
of anything better yet. We can always change this later.
That's all! Requesting initial review of the plist from Smokey since he'll catch any nits.
Attachment #295143 -
Attachment is obsolete: true
Attachment #295600 -
Flags: review?(alqahira)
Comment on attachment 295600 [details]
Bookmark plist v1.0
Please override the MIME type when uploading any sort of text file without a .txt/.(x)html/.xml extension, since Bugzilla has a very small set of extension->MIME type mappings ;)
> <key>Title</key>
> <string>Apple - Mac OS X - Downloads</string>
There's no " - Mac OS X" in the title on the actual site any more.
> <key>Title</key>
> <string>VersionTracker: Mac OS X Software</string>
That colon looks odd there, since none of the other sites have it (and neither does the actual VT site any more); how about "VersionTracker - Mac OS X Software" or "VersionTracker - Mac OS X Software Updates"? Or, since none of the other sites (that don't have real 'sections') have hyphenated crap, just "VersionTracker"?
> <string>Mac Software</string>
> <key>UUID</key>
> <string>A5A5719E-F51D-4E5F-A3EE-A32EFE217903</string>
Get rid of the UUID here, so that it can truly be universally unique when created.
> <key>Title</key>
> <string>WordPress</string>
They brand themselves WordPress.com both in the title and on the page, so let's do that, too.
> <dict>
> <key>LastVisitedDate</key>
> <date>2008-01-06T08:00:00Z</date>
> <key>Status</key>
> <integer>0</integer>
> <key>Title</key>
> <string>Camino</string>
> <key>URL</key>
> <string>http://caminobrowser.org/</string>
> <key>VisitCount</key>
> <integer>0</integer>
> </dict>
For some reason I thought this had the shortcut "camino" (since, um, our documentation says so); can we add the shortcut (né keyword) here?
> <key>Title</key>
> <string>PimpMyCamino</string>
I wonder if maybe we want to demonstrate the "Description" field here, with something like "Unofficial site for third-party add-ons and themes for Camino"?
> <key>Title</key>
> <string>Amazon</string>
Similarly, make this Amazon.com like the site itself uses.
Otherwise, looks good; r=ardissone with those changes.
As to why we don't write a bunch of empty keys now (compared to the old bookmarks.plist), a smfr cleanup/speedup patch from 2005 notes we stopped writing empty keys for size and speed wins ;)
Attachment #295600 -
Attachment mime type: application/octet-stream → text/plain
Attachment #295600 -
Flags: review?(alqahira) → review+
| Assignee | ||
Comment 33•18 years ago
|
||
Apparently I missed Shopping on the last go around... adding it here. Also addressed all of Smokey's comments. Even though he r+ed, re-requesting from him since I added new bookmarks.
Mark brought up the "why" for having a date in the plist. If we remove the date from the defaults, it gets added the first time Camino is run and is set to that initial date. That may be okay, not sure. It's an easy fix to either change the date or remove it altogether.
Attachment #295600 -
Attachment is obsolete: true
Attachment #295854 -
Flags: review?(alqahira)
Comment on attachment 295854 [details]
Bookmark plist v1.1 (now with Shopping!)
> <key>Title</key>
> <string>Apple - Support</string>
> <key>URL</key>
> <string>http://www.apple.com/support/</string>
>
> <key>VisitCount</key>
What's with this blank line?
> <key>Title</key>
> <string>Mac OS X Hints</string>
> <key>URL</key>
> <string>http://www.macosxhints.com/</string>
>
> <key>VisitCount</key>
And this one?
> <key>FolderType</key>
> <integer>0</integer>
> <key>Title</key>
> <string>Mac News & Support</string>
> <key>UUID</key>
> <string>8298C473-186C-4860-AF33-2D1E5E276872</string>
Please de-UUID.
> <key>Title</key>
> <string>Amazon.com</string>
> <key>URL</key>
> <string>http://www.amazon.com/</string>
> <key>VisitCount</key>
> <integer>1</integer>
Let's start out with 0 visits ;)
> <key>FolderType</key>
> <integer>2</integer>
> <key>Title</key>
> <string>Bookmarks</string>
Make sure this FolderType stays 2 if you have to go back into Camino; that seems to be what it's supposed to be (but your last version had it 0).
Other than those, this looks good. r=ardissone with those changes, which should be possible without using Camino.
Oh, and if we're doing special dates and times, 01/29/2002 10:01:11 UTC is my vote ;)
Attachment #295854 -
Flags: review?(alqahira) → review+
| Assignee | ||
Comment 35•18 years ago
|
||
I ain't going back into Camino for no one!!
But really, nits fixed, carrying forward review. Mark, you're up!
Attachment #295854 -
Attachment is obsolete: true
Attachment #295903 -
Flags: superreview?(mark)
Attachment #295903 -
Flags: review+
Comment 36•18 years ago
|
||
Comment on attachment 295903 [details]
Bookmark plist v1.1.1
Nice list. Let's go with "Social" for now but keep our thinking caps on for a better name.
Minor changes:
>iusethis mac software
>craigslist classifieds
We can respect both of their wishes to style their proper names in all lowercase letters, but I think the category names should still be capitalized for inclusion in our menu. "iusethis Mac Software" and "craigslist Classifieds". Sure, both strings will look silly on their own, but I think this looks better in the context of the entire menu.
>http://en.wikipedia.org/wiki/Main_Page
Looks like you've gone to great lengths to eliminate redirects, which is cool, but I think this one should go in as http://en.wikipedia.org/ . Sure, /wiki/Main_Page is probably close-to-guaranteed to always work, but if Wikipedia decides to map the / page elsewhere, our bookmark should respect their wishes.
(Earlier in the file, I almost didn't comment about:)
>http://db.tidbits.com/
Again, nice job on the redirect elimination, but I have no idea what "db" is supposed to signify, and I'm wary of its future-proof safety. I'd feel more comfortable with tidbits.com or www.tidbits.com here.
>http://caminobrowser.org/
Guess we've decided that this one is going to be our permanent identity now? Cool. Make sure that at least one of the e-mail/postal addresses used for the domain name's registration are set to something where more than one person can receive and act on any mail. Let's also update what we've got in WebsiteDefaults.strings, Credits.rtf, and anywhere else we might have stuck a reference to the project site.
>http://www.mozilla.org
Trailing slash, please.
>New York Times
The "the" is actually part of their proper name, so "The New York Times".
>Oh, and if we're doing special dates and times, 01/29/2002
>10:01:11 UTC is my vote ;)
Kid's birthday? I've got no problem with that, but I'd actually like to fix Camino to display "never" if there's no date, to not insert a date for the default bookmarks on first launch, and to ship without last-visited dates for all of the default bookmarks. Is there a bug for that yet? The date changes with respect to this file are all easy enough, so there's no need to worry about them here as long as we've got a new bug to handle the codeness.
Attachment #295903 -
Flags: superreview?(mark) → superreview+
| Assignee | ||
Comment 37•18 years ago
|
||
This makes all the requested changes including changing the date and should be ready for checkin.
Attachment #295044 -
Attachment is obsolete: true
Attachment #295903 -
Attachment is obsolete: true
Comment 38•18 years ago
|
||
Bug 411338 will let us have no value for the last-visited time. When that's in, we should remove all LastVisitedDate and VisitCount keys, since that's how Camino will write bookmarks.plist entries with no visits.
Landed on the trunk and MOZILLA_1_8_BRANCH. Clearing those requests since we're far in advance of both milestones.
We do need to come up with some guidelines for localization, though.
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: camino1.6b2?
Flags: camino1.6?
Keywords: fixed1.8.1.12
Resolution: --- → FIXED
| Assignee | ||
Comment 40•18 years ago
|
||
(In reply to comment #39)
> We do need to come up with some guidelines for localization, though.
Filed as bug 411371.
You need to log in
before you can comment on or make changes to this bug.
Description
•