411338 - Allow "never" as a last-visited time for bookmarks

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Mark Mentovai]

We should allow nil values for a bookmark's last-visited time.  Right now, a last-visited time is required, and by default, a bookmark's last-visited time will be the time the bookmark object was created.  This isn't right for bookmarks that are created without visits, such as those dragged or pasted in, or those in the default bookmarks list (bug 377934).

If a bookmark dictionary doesn't have a value for LastVisitedDate, it should be treated as a nil last-visited time, and the last visit time should be displayed as "Never" (localized) in the UI (in the Bookmark Info window).

When we do create bookmarks from visited pages, we should set the visit count to at least 1, since the page was visited in order to create the bookmark.  We can continue setting the last visit time to the current time, but in the future, we can change this to set it to the time that the page was loaded, or in the case of bookmarks pasted or dragged from history items, to the time of the history item.

Comment 1

[Mark Mentovai]

Attachment: Let bookmarks exist without a last-visited time, create bookmarks with a last-visited time only if created by visiting a page

I also hate the default format string used for the last-visited date in the nib, but fixing it the right way will probably be 10.4-only and only suitable for the trunk.

Comment 2

[Stuart Morgan]

Comment on attachment 296027 [details] [diff] [review]
Let bookmarks exist without a last-visited time, create bookmarks with a last-visited time only if created by visiting a page

r=me

>   if ((self = [super init])) {
>-    mURL            = [[NSString alloc] init];
>+    mURL            = nil;
>     mIsSeparator    = NO;
>     mNumberOfVisits = 0;
>-    mLastVisit      = [[NSDate date] retain];
>+    mLastVisit      = nil;

I'd rather we just axe everything here, since none of it is necessary.

As for fixing the format string, if what you want is the 10.4 non-crappy behavior you could take the CFDateFormatter-based formatter I made for cookies and make it shared in the meantime (depending on how much you care).

Comment 3

[Mark Mentovai]

Checked in on the trunk and MOZILLA_1_8_BRANCH for 1.6b1.

Comment 4

[Mark Mentovai]

(In reply to comment #2)
> As for fixing the format string, if what you want is the 10.4 non-crappy
> behavior you could take the CFDateFormatter-based formatter I made for cookies
> and make it shared in the meantime (depending on how much you care).

Bug 411516.