Closed Bug 377956 Opened 14 years ago Closed 12 years ago

Tabular and graphical reports should support single-select custom fields

Categories

(Bugzilla :: Reporting/Charting, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.4

People

(Reporter: altlist, Assigned: LpSolit)

Details

Attachments

(1 file, 3 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: 

Now that we have custom fields, the tabular report ought to also support them.  In particular, I would like to be able to output a 2d table, with one of the axis be based on a pull-down custom field.  

Reproducible: Always
I thought this was a dupe, but I cannot find it.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → 3.0
I'm not able to change the subject line, but this also impacts the search queries.  Or rather, the query system is a LOT easier to use if the custom pull-down fields were treated a multi-select fields, rather than in the advanced section.

It was easy to hack the files to support my own custom field names.  But would need to make this user configurable...
Component: Reporting/Charting → Query/Bug List
Attached patch patch, v1 (obsolete) — Splinter Review
Trivial to fix. What a pity we didn't implement it for 3.2.
Assignee: gerv → LpSolit
Status: NEW → ASSIGNED
Attachment #355174 - Flags: review?(mkanat)
Attachment #355174 - Flags: review?(gerv)
Component: Query/Bug List → Reporting/Charting
Target Milestone: --- → Bugzilla 3.4
Attached patch patch, v1.1 (obsolete) — Splinter Review
Better fix. You can now edit the tabular/graphical report and have fields correctly populated.
Attachment #355174 - Attachment is obsolete: true
Attachment #355177 - Flags: review?(mkanat)
Attachment #355177 - Flags: review?(gerv)
Attachment #355174 - Flags: review?(mkanat)
Attachment #355174 - Flags: review?(gerv)
Comment on attachment 355177 [details] [diff] [review]
patch, v1.1

Sure, this looks fine. We should probably move a lot of the report.cgi stuff into some module somewhere, so that we don't have duplicate code around Bugzilla, but that's for some future bug.
Attachment #355177 - Flags: review?(mkanat) → review+
Attached patch patch, v1.2 (obsolete) — Splinter Review
$vars is not declared using 'local our', so PrefillForm() won't have access to it in mod_perl.
Attachment #355177 - Attachment is obsolete: true
Attachment #355182 - Flags: review?(mkanat)
Attachment #355177 - Flags: review?(gerv)
Comment on attachment 355182 [details] [diff] [review]
patch, v1.2

That looks fine, but you can remove the comment about "this code must be called before PrefillForm" now, and maybe even move the code somewhere closer to where the template is generated?
Attachment #355182 - Flags: review?(mkanat) → review+
Attached patch patch, v1.3Splinter Review
OK, comment removed, and code moved to a better place (the one of the initial patch). Carrying forward mkanat's r+.
Attachment #355182 - Attachment is obsolete: true
Attachment #355184 - Flags: review+
Flags: approval+
Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.182; previous revision: 1.181
done
Checking in report.cgi;
/cvsroot/mozilla/webtools/bugzilla/report.cgi,v  <--  report.cgi
new revision: 1.43; previous revision: 1.42
done
Checking in template/en/default/search/search-report-select.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-report-select.html.tmpl,v  <--  search-report-select.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: relnote
Resolution: --- → FIXED
Summary: Update Tabular reports to support pull-down custom fields → Tabular and graphical reports should support single-select custom fields
Added to the release notes for Bugzilla 3.4 in bug 494037.
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.