377956 - Tabular and graphical reports should support single-select custom fields

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, enhancement)

Description

[Albert Ting]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: 

Now that we have custom fields, the tabular report ought to also support them.  In particular, I would like to be able to output a 2d table, with one of the axis be based on a pull-down custom field.  

Reproducible: Always

Comment 1

[Frédéric Buclin]

I thought this was a dupe, but I cannot find it.

Comment 2

[Albert Ting]

I'm not able to change the subject line, but this also impacts the search queries.  Or rather, the query system is a LOT easier to use if the custom pull-down fields were treated a multi-select fields, rather than in the advanced section.

It was easy to hack the files to support my own custom field names.  But would need to make this user configurable...

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Trivial to fix. What a pity we didn't implement it for 3.2.

Comment 4

[Frédéric Buclin]

Attachment: patch, v1.1

Better fix. You can now edit the tabular/graphical report and have fields correctly populated.

Comment 5

[Max Kanat-Alexander]

Comment on attachment 355177 [details] [diff] [review]
patch, v1.1

Sure, this looks fine. We should probably move a lot of the report.cgi stuff into some module somewhere, so that we don't have duplicate code around Bugzilla, but that's for some future bug.

Comment 6

[Frédéric Buclin]

Attachment: patch, v1.2

$vars is not declared using 'local our', so PrefillForm() won't have access to it in mod_perl.

Comment 7

[Max Kanat-Alexander]

Comment on attachment 355182 [details] [diff] [review]
patch, v1.2

That looks fine, but you can remove the comment about "this code must be called before PrefillForm" now, and maybe even move the code somewhere closer to where the template is generated?

Comment 8

[Frédéric Buclin]

Attachment: patch, v1.3

OK, comment removed, and code moved to a better place (the one of the initial patch). Carrying forward mkanat's r+.

Comment 9

[Frédéric Buclin]

Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.182; previous revision: 1.181
done
Checking in report.cgi;
/cvsroot/mozilla/webtools/bugzilla/report.cgi,v  <--  report.cgi
new revision: 1.43; previous revision: 1.42
done
Checking in template/en/default/search/search-report-select.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-report-select.html.tmpl,v  <--  search-report-select.html.tmpl
new revision: 1.8; previous revision: 1.7
done

Comment 10

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.4 in bug 494037.