378340 - SpamAssasin typo in mailnews.js - causes "trust spamassassin" not to work

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Discovered thanks to a strange and terrible thread in m.d.a.seamonkey. STR are hard to come by - I suspect that extension .sfd come first, and would work as a step, but otherwise you either have to fool your filesystem into delivering something before SpamAssassin.sfd, or have both SpamAssassin.sfd and SpamAssasin.sfd, to see that sin.sfd is selected by default, rather than ssin.sfd.

Comment 1

[Atlanx]

I can choose between
  SpamAssasin
  SpamAssassin
  SpamPal
in Seamonkey 1.1

Question: I can choose "SpamAssasin" in Seamonkey(german (at).
Has this to do with this bug here?
And will this seamonkey bug get fixed with your fix here in seamonkey, too?

Thank you for your answer.

Comment 2

[Scott MacGregor]

Comment on attachment 262392 [details] [diff] [review]
Fix v.1

good catch!

Comment 3

[Phil Ringnalda (:philor)]

mailnews/mailnews.js 3.296

(In reply to comment #1)
> Has this to do with this bug here?

Not really, no; replied in m.d.a.seamonkey instead.

Comment 4

[Magnus Melin [:mkmelin]]

Updating summary and severity as is seems this was causing bug 381589.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 262392 [details] [diff] [review]
Fix v.1

This very safe little patch should go on branch too, as it seems to fix bug 381589.

Comment 7

[Phil Ringnalda (:philor)]

Oh, crap. Yes, this is a good branch-safe workaround for the broken-by-design way am-junk handles the default value.

Comment 8

[Daniel Veditz [:dveditz]]

Not blocking, but we'll look at the patch.

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 262392 [details] [diff] [review]
Fix v.1

approved for 1.8.1.12, a=dveditz for release-drivers

Comment 10

[Phil Ringnalda (:philor)]

mailnews/mailnews.js 3.249.2.39