Last Comment Bug 378535 - [FIX]Implement "content: none"
: [FIX]Implement "content: none"
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla1.9alpha5
Assigned To: Boris Zbarsky [:bz] (still a bit busy)
:
Mentors:
Depends on:
Blocks: 377731
  Show dependency treegraph
 
Reported: 2007-04-23 18:59 PDT by Boris Zbarsky [:bz] (still a bit busy)
Modified: 2007-04-26 21:43 PDT (History)
3 users (show)
bzbarsky: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix (4.29 KB, patch)
2007-04-23 18:59 PDT, Boris Zbarsky [:bz] (still a bit busy)
no flags Details | Diff | Splinter Review
With tests too (6.77 KB, patch)
2007-04-23 19:06 PDT, Boris Zbarsky [:bz] (still a bit busy)
dbaron: review+
dbaron: superreview+
Details | Diff | Splinter Review

Description Boris Zbarsky [:bz] (still a bit busy) 2007-04-23 18:59:57 PDT
Created attachment 262584 [details] [diff] [review]
Fix

It's easy; might as well
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2007-04-23 19:06:28 PDT
Created attachment 262585 [details] [diff] [review]
With tests too
Comment 2 Jesse Ruderman 2007-04-23 19:28:07 PDT
Is the first hunk of the patch for a different bug?
Comment 3 Boris Zbarsky [:bz] (still a bit busy) 2007-04-23 19:36:34 PDT
er, yes.  And it's already checked in, in fact...
Comment 4 David Baron :dbaron: ⌚️UTC-7 (busy September 14-25) 2007-04-23 20:13:10 PDT
I'm pretty sure this'll turn a few mochitest todos into passing.
Comment 5 Boris Zbarsky [:bz] (still a bit busy) 2007-04-23 20:51:56 PDT
I'll watch out for it.  ;)
Comment 6 David Baron :dbaron: ⌚️UTC-7 (busy September 14-25) 2007-04-25 16:48:41 PDT
Comment on attachment 262585 [details] [diff] [review]
With tests too

r+sr=dbaron

Please update the mochitest todos in test_value_storage.html and test_value_computation.html (by removing the line that notes content:none is unimplemented), and run the mochitests before checkin.  (See bug 279246 comment 41 for instructions if you need them.)
Comment 7 Boris Zbarsky [:bz] (still a bit busy) 2007-04-26 21:43:05 PDT
Checked in, with the mochitest changes.

Note You need to log in before you can comment on or make changes to this bug.