pass style system mochitests (without asserting)

NEW
Unassigned

Status

()

Core
CSS Parsing and Computation
11 years ago
10 years ago

People

(Reporter: dbaron, Unassigned)

Tracking

({meta})

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I'm writing a bunch of mochitests to test the style system.  I've been filing bugs on some of the failures, but I'm not keeping up with the bug filing that needs to be done, never mind the fixing.

So this bug is a meta-bug on getting us to pass all of the tests in layout/style/test/ that don't have bug numbers in the test filenames.  Dependency bugs should be added as they are filed.
Depends on: 258080
Depends on: 227695
Created attachment 262084 [details] [diff] [review]
some one-line patches

I said I'd file separate bugs, but these are one-liners that don't seem worthy of their own bug reports:
 * serialize 'cue' shorthand in the correct order
 * serialize 'pause' shorthand in the correct order
 * accept 'none' for 'speak-punctuation' (this is all that's needed since we don't compute values for any of the aural properties)
 * accept 'none' followed by a cue-after value in 'cue' parsing
 * don't check '-moz-box-orient: inherit' when computing '-moz-box-flex'
Attachment #262084 - Flags: superreview?(bzbarsky)
Attachment #262084 - Flags: review?(bzbarsky)
Comment on attachment 262084 [details] [diff] [review]
some one-line patches

Looks good.
Attachment #262084 - Flags: superreview?(bzbarsky)
Attachment #262084 - Flags: superreview+
Attachment #262084 - Flags: review?(bzbarsky)
Attachment #262084 - Flags: review+
Comment on attachment 262084 [details] [diff] [review]
some one-line patches

Checked in to trunk.
Depends on: 378535
We also need to look at the assertions that fire during the tests.
Summary: pass style system mochitests → pass style system mochitests (without asserting)
Depends on: 379316
Depends on: 379405
Depends on: 372063
Depends on: 379906

Updated

11 years ago
Depends on: 379951
Depends on: 229092
Depends on: 241234
Depends on: 80887
Depends on: 389404
Depends on: 389406
Depends on: 376075
Depends on: 470703
Depends on: 470704
Depends on: 470706
You need to log in before you can comment on or make changes to this bug.