Open
Bug 377731
Opened 18 years ago
Updated 2 years ago
[meta] pass style system mochitests (without asserting)
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
NEW
People
(Reporter: dbaron, Unassigned)
References
Details
(Keywords: meta)
Attachments
(1 file)
5.04 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
I'm writing a bunch of mochitests to test the style system. I've been filing bugs on some of the failures, but I'm not keeping up with the bug filing that needs to be done, never mind the fixing.
So this bug is a meta-bug on getting us to pass all of the tests in layout/style/test/ that don't have bug numbers in the test filenames. Dependency bugs should be added as they are filed.
Reporter | ||
Comment 1•18 years ago
|
||
I said I'd file separate bugs, but these are one-liners that don't seem worthy of their own bug reports:
* serialize 'cue' shorthand in the correct order
* serialize 'pause' shorthand in the correct order
* accept 'none' for 'speak-punctuation' (this is all that's needed since we don't compute values for any of the aural properties)
* accept 'none' followed by a cue-after value in 'cue' parsing
* don't check '-moz-box-orient: inherit' when computing '-moz-box-flex'
Attachment #262084 -
Flags: superreview?(bzbarsky)
Attachment #262084 -
Flags: review?(bzbarsky)
Comment 2•18 years ago
|
||
Comment on attachment 262084 [details] [diff] [review]
some one-line patches
Looks good.
Attachment #262084 -
Flags: superreview?(bzbarsky)
Attachment #262084 -
Flags: superreview+
Attachment #262084 -
Flags: review?(bzbarsky)
Attachment #262084 -
Flags: review+
Reporter | ||
Comment 3•18 years ago
|
||
Comment on attachment 262084 [details] [diff] [review]
some one-line patches
Checked in to trunk.
Reporter | ||
Comment 4•18 years ago
|
||
We also need to look at the assertions that fire during the tests.
Summary: pass style system mochitests → pass style system mochitests (without asserting)
Updated•2 years ago
|
Severity: normal → S3
Updated•2 years ago
|
Summary: pass style system mochitests (without asserting) → [meta] pass style system mochitests (without asserting)
You need to log in
before you can comment on or make changes to this bug.
Description
•