378571 - extending array prototype makes tree binding fail

Status: RESOLVED DUPLICATE of bug 318036

(Toolkit :: UI Widgets, defect)

Description

[Christian Pernot]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: XULRunner 1.8.0.4

hello,

I use a JSON library that extends various objects prototypes with the "toJSONString" function.

this is the case for Array object.

after that, when clicking on a tree columnpicker button, I get an error "element has no properties" file: tree.xml line: 965.

here is the code:

--snip--

const anonids = ["menuseparator", "menuitem"];
for (var anonid in anonids) {
   var element = document.getAnonymousElementByAttribute(this, "anonid", anonids[anonid]);
   element.hidden = hidden;
}

--snip--

doing a for(var i in array) return prototype extensions too (functions).

I correct this in my own code by using array.hasOwnProperty(i) in the loop.

Is there a workaround for that? 

Reproducible: Always

Steps to Reproduce:
1. include http://www.json.org/json.js in a XUL window
2. put a tree into into the window with a columnpicker
3. click on the columnpicker button
Actual Results:  
javascript error : element has no properties" file: tree.xml line: 965.

Expected Results:  
columnpicker menu should appear

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This is already fixed on the trunk.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Hmm, though it should be fixed on the branch too. Which build are you testing? 2.0.0.3 should have the fix...

Comment 3

[Christian Pernot]

yes it is already fixed,

I misread the 1.8 branch code.

I use the 1.8.0 branch (xulrunner)

thanks