318036 - adding to Array.prototype breaks a tree column picker

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Ryan Davis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

The code to show a column picker is using the "in" keyword to iterate over an array, and any functions added to Array via Array.prototype are being iterated over as well, and the code is failing when it tries to document.getAnonymousElementByAttribute with a function.

Reproducible: Always

Steps to Reproduce:
1. See URL demostrating problem
2. Open the column picker
3. Click the "break column picker" button, which adds to Array.prototype
4. Open the column picker
Actual Results:  
column picker stutters open

Expected Results:  
column picker opens

changing this not use the "in" keyword will solve the problem.  A lot of javascript libraries add convienence functions to Array.prototype, so this is probably broken on many xul apps.

Comment 1

[Ryan Davis]

Attachment: simple testcase

this is the sample that should be accessible at http://birdman.acceleration.net/ryan/treeProblems.xul

Comment 2

[Ryan Davis]

This is the same class of bug as https://bugzilla.mozilla.org/show_bug.cgi?id=309046, using the "in" keyword for iteration.

Comment 3

[Ryan Davis]

Attachment: Not the right patch format, ignore

Comment 4

[Ryan Davis]

Attachment: cvs diff to fix this bug

Proper cvs diff against the head. (I think)

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 204559 [details] [diff] [review]
cvs diff to fix this bug

Tossing to mano, I'm on vacation until Monday

Comment 6

[Asaf Romano (gone)]

Comment on attachment 204559 [details] [diff] [review]
cvs diff to fix this bug

r=mano.

Comment 7

[Ryan Davis]

Since this passed review, can it please be checked in?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Yes, sorry about that, I will check it in later today.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Checked in on the trunk. Thanks for the bug report and patch, Ryan!

mozilla/toolkit/content/widgets/tree.xml; new revision: 1.24;

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Checked in on the 1.8 branch for Firefox 2.
mozilla/toolkit/content/widgets/tree.xml; new revision: 1.21.2.1;