378632 - Viewing history by site in sidebar doesn't organise by site

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dave Townsend [:mossop] (PTO until Aug 21st)]

If you open the history sidebar and choode to view by site, the urls are just all listed, there is no organisation by site at all. Viewing by date and site does work as expected, though I appear to have a couple of broken entries like "false;".

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a4pre) Gecko/20070424 Minefield/3.0a4pre ID:2007042402 [cairo]

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of build 20070607 on Vista

Dave, still messed up for you?

Comment 2

[Dave Townsend [:mossop] (PTO until Aug 21st)]

All OS as per comment 1. I'm also seeing an issue with the scrollbar not working right but that may be more cocoa widget related.

Comment 3

[Dave Townsend [:mossop] (PTO until Aug 21st)]

For some reason I was under the impression that this was supposed to display a folder view like by date and site does so comment 1 actually shows this working as it should. However mine is still not right, it's just listing the pages in title order.

Comment 4

[Asaf Romano (gone)]

So...

 * Sort By Site does not group, it just sorts.
 * Sorts, by title.
 * In Fx2 too, and that's not even filed.

I think we should either change this to actually group by host or rename the menu-item to "Sort By Title".

Comment 5

[Dave Townsend [:mossop] (PTO until Aug 21st)]

I quite often find myself having to dig through all the date groups to find a result from a given site so I'd vote for proper grouping by site.

That said I was surprised to just realise that there wasnt just a sort by name option, but then I think you can just search in that instance.

Comment 6

[Asaf Romano (gone)]

Attachment: the former

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 270167 [details] [diff] [review]
the former

r=me, let's get this landed

Comment 9

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Attachment: unbitrotted

Comment 10

[Asaf Romano (gone)]

Thanks Dave.

Checking in browser/components/places/content/history-panel.js;
/cvsroot/mozilla/browser/components/places/content/history-panel.js,v  <--  history-panel.js
new revision: 1.23; previous revision: 1.22
done

Comment 11

[Mikel Ward]

Is there a bug to implement Sort By Title (the latter option)?

Comment 12

[(not reading, please use [e-mail] instead)]

> Is there a bug to implement Sort By Title (the latter option)?

see bug #394024

Comment 13

[Tracy Walker [:tracy]]

verified with - Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091304 Minefield/3.0a8pre

sorted by sites shows folders containing pages for each site visited.

Comment 14

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv