Closed
Bug 378762
Opened 17 years ago
Closed 17 years ago
Add echo-variable-% for client.mk vars
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: Pike, Assigned: Pike)
Details
(Keywords: fixed1.8.1.4, verified1.8.1.4)
Attachments
(1 file, 1 obsolete file)
655 bytes,
patch
|
Pike
:
review+
Pike
:
approval1.8.1.4+
|
Details | Diff | Splinter Review |
I'd like to open the existing backdoor in client.mk to actually get any client.mk variable out of it. That would enable me to actually use the variable definitions for modules and locales and all that from outside make, i.e. python and buildbot. The existing backdoor echo_objdir was added for camino (bug 201860), but isn't used anymore, so I'd like to tweak it to actually work for echo_%.
Attachment #262782 -
Flags: review?(benjamin)
Comment 1•17 years ago
|
||
Comment on attachment 262782 [details] [diff] [review] morph echo_ backdoor to work for all vars as discussed on IRC, I'd like this to be echo-variable-%
Attachment #262782 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 2•17 years ago
|
||
This is the patch that I landed on the trunk, attaching here for branch landing, too.
Assignee: nobody → l10n
Attachment #262782 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #263022 -
Flags: review+
Assignee | ||
Updated•17 years ago
|
Summary: Add backdoor for client.mk vars → Add echo-variable-% for client.mk vars
Assignee | ||
Comment 3•17 years ago
|
||
Comment on attachment 263022 [details] [diff] [review] patch landed on trunk Per discussion on irc with dveditz, this is good for the branch. Requesting approval1.8.1.4.
Attachment #263022 -
Flags: approval1.8.1.4?
Assignee | ||
Comment 4•17 years ago
|
||
Comment on attachment 263022 [details] [diff] [review] patch landed on trunk approving for landing for 1.8.1.4, as per discussion with dveditz on irc.
Attachment #263022 -
Flags: approval1.8.1.4? → approval1.8.1.4+
Assignee | ||
Comment 5•17 years ago
|
||
FIXED on both trunk and MOZILLA_1_8_BRANCH
Updated•17 years ago
|
Flags: in-testsuite-
verified that the code did land on branch and trunk, marking verified.
Status: RESOLVED → VERIFIED
Keywords: verified1.8.1.4
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•