The default bug view has changed. See this FAQ.

Add echo-variable-% for client.mk vars

VERIFIED FIXED

Status

()

Core
Build Config
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

({fixed1.8.1.4, verified1.8.1.4})

Trunk
fixed1.8.1.4, verified1.8.1.4
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 262782 [details] [diff] [review]
morph echo_ backdoor to work for all vars

I'd like to open the existing backdoor in client.mk to actually get any client.mk variable out of it. That would enable me to actually use the variable definitions for modules and locales and all that from outside make, i.e. python and buildbot.

The existing backdoor echo_objdir was added for camino (bug 201860), but isn't used anymore, so I'd like to tweak it to actually work for echo_%.
Attachment #262782 - Flags: review?(benjamin)
Comment on attachment 262782 [details] [diff] [review]
morph echo_ backdoor to work for all vars

as discussed on IRC, I'd like this to be echo-variable-%
Attachment #262782 - Flags: review?(benjamin) → review+
(Assignee)

Comment 2

10 years ago
Created attachment 263022 [details] [diff] [review]
patch landed on trunk

This is the patch that I landed on the trunk, attaching here for branch landing, too.
Assignee: nobody → l10n
Attachment #262782 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #263022 - Flags: review+
(Assignee)

Updated

10 years ago
Summary: Add backdoor for client.mk vars → Add echo-variable-% for client.mk vars
(Assignee)

Comment 3

10 years ago
Comment on attachment 263022 [details] [diff] [review]
patch landed on trunk

Per discussion on irc with dveditz, this is good for the branch. Requesting approval1.8.1.4.
Attachment #263022 - Flags: approval1.8.1.4?
(Assignee)

Comment 4

10 years ago
Comment on attachment 263022 [details] [diff] [review]
patch landed on trunk

approving for landing for 1.8.1.4, as per discussion with dveditz on irc.
Attachment #263022 - Flags: approval1.8.1.4? → approval1.8.1.4+
(Assignee)

Comment 5

10 years ago
FIXED on both trunk and MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed1.8.1.4
Resolution: --- → FIXED
Flags: in-testsuite-

Comment 6

10 years ago
verified that the code did land on branch and trunk, marking verified.
Status: RESOLVED → VERIFIED
Keywords: verified1.8.1.4
You need to log in before you can comment on or make changes to this bug.