I'd like to open the existing backdoor in client.mk to actually get any client.mk variable out of it. That would enable me to actually use the variable definitions for modules and locales and all that from outside make, i.e. python and buildbot. The existing backdoor echo_objdir was added for camino (bug 201860), but isn't used anymore, so I'd like to tweak it to actually work for echo_%.
Attachment #262782 - Flags: review?(benjamin)
Comment on attachment 262782 [details] [diff] [review] morph echo_ backdoor to work for all vars as discussed on IRC, I'd like this to be echo-variable-%
Attachment #262782 - Flags: review?(benjamin) → review+
This is the patch that I landed on the trunk, attaching here for branch landing, too.
Summary: Add backdoor for client.mk vars → Add echo-variable-% for client.mk vars
Comment on attachment 263022 [details] [diff] [review] patch landed on trunk Per discussion on irc with dveditz, this is good for the branch. Requesting approval18.104.22.168.
Attachment #263022 - Flags: approval22.214.171.124?
Comment on attachment 263022 [details] [diff] [review] patch landed on trunk approving for landing for 126.96.36.199, as per discussion with dveditz on irc.
Attachment #263022 - Flags: approval188.8.131.52? → approval184.108.40.206+
FIXED on both trunk and MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
verified that the code did land on branch and trunk, marking verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.