Closed Bug 378839 Opened 13 years ago Closed 13 years ago
unescape of properties files is broken
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070425 Minefield/3.0a4pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070425 Minefield/3.0a4pre ID:2007042510 unescape of escaped-unicode (\uXXXX format) is broken. Reproducible: Always Steps to Reproduce: 1. Go to the URL Actual Results: The image “S” cannot be displayed, because it contains errors. Expected Results: The image “data:image/png,foo” cannot be displayed, because it contains errors. regression range: between 2007042507 and 2007042508 maybe Bug 365345 causes this.
Seems likely from the regression range
Assignee: nobody → smontagu
http://lxr.mozilla.org/mozilla/source/dom/locales/en-US/chrome/layout/MediaDocument.properties#53 > InvalidImage=The image \u201c%S\u201d cannot be displayed, because it contains errors. \u201c%S\u201d must be unescaped to “%S” but it seems actually unescaped to “S”
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 262861 [details] [diff] [review] patch sr=biesi, but I'm not an xpcom peer...
Attachment #262861 - Flags: review?(benjamin)
We should either get this in for 1.9a4, or back out bug 365345.
actually, perhaps you should use Append(ch) instead of the --i. That may be easier to understand.
13 years ago
OS: Windows XP → All
Hardware: PC → All
How would that work if there were two consecutive escapes?
oh.. you're right. ok, the --i is better :)
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.