Closed
Bug 378839
Opened 17 years ago
Closed 17 years ago
unescape of properties files is broken
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: dev-null, Assigned: smontagu)
References
()
Details
Attachments
(1 file)
1.20 KB,
patch
|
benjamin
:
review+
Biesinger
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070425 Minefield/3.0a4pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070425 Minefield/3.0a4pre ID:2007042510 unescape of escaped-unicode (\uXXXX format) is broken. Reproducible: Always Steps to Reproduce: 1. Go to the URL Actual Results: The image “S” cannot be displayed, because it contains errors. Expected Results: The image “data:image/png,foo” cannot be displayed, because it contains errors. regression range: between 2007042507 and 2007042508 maybe Bug 365345 causes this.
Reporter | ||
Comment 2•17 years ago
|
||
http://lxr.mozilla.org/mozilla/source/dom/locales/en-US/chrome/layout/MediaDocument.properties#53 > InvalidImage=The image \u201c%S\u201d cannot be displayed, because it contains errors. \u201c%S\u201d must be unescaped to “%S” but it seems actually unescaped to “S”
Assignee | ||
Updated•17 years ago
|
Assignee | ||
Comment 3•17 years ago
|
||
Attachment #262861 -
Flags: superreview?
Attachment #262861 -
Flags: review?
Assignee | ||
Updated•17 years ago
|
Attachment #262861 -
Flags: superreview?(cbiesinger)
Attachment #262861 -
Flags: superreview?
Attachment #262861 -
Flags: review?(cbiesinger)
Attachment #262861 -
Flags: review?
Comment 4•17 years ago
|
||
Comment on attachment 262861 [details] [diff] [review] patch sr=biesi, but I'm not an xpcom peer...
Attachment #262861 -
Flags: superreview?(cbiesinger)
Attachment #262861 -
Flags: superreview+
Attachment #262861 -
Flags: review?(cbiesinger)
Assignee | ||
Updated•17 years ago
|
Attachment #262861 -
Flags: review?(benjamin)
Assignee | ||
Comment 5•17 years ago
|
||
We should either get this in for 1.9a4, or back out bug 365345.
Flags: blocking1.9?
Comment 6•17 years ago
|
||
actually, perhaps you should use Append(ch) instead of the --i. That may be easier to understand.
Updated•17 years ago
|
OS: Windows XP → All
Hardware: PC → All
Assignee | ||
Comment 7•17 years ago
|
||
How would that work if there were two consecutive escapes?
Comment 8•17 years ago
|
||
oh.. you're right. ok, the --i is better :)
Updated•17 years ago
|
Attachment #262861 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 9•17 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Flags: in-testsuite?
Assignee | ||
Updated•17 years ago
|
Flags: in-testsuite?
Flags: in-testsuite+
Flags: blocking1.9?
You need to log in
before you can comment on or make changes to this bug.
Description
•