378921 - unable to bookmark a microsummarized URI

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dietrich Ayala (:dietrich)]

STR:
1. install microsummary at http://dietrich.ganx4.com/mozilla/test-microsummary.xml
2. go to http://dietrich.ganx4.com/mozilla/test-microsummary-content.php and bookmark it

The add-bookmark dialog doesn't load, and i get this error:

WARNING: Remote chrome not allowed! Only file:, resource:, and jar: are valid.
: file /Users/dayala/moz/newplaces/mozilla/chrome/src/nsChromeProtocolHandler.cpp, line 565

however, if you then restart the app, and try to bookmark the page again, it works as expected.

mconnor said he got this error when editing a microsummarized bookmark:

[Exception... "'Component does not have requested interface' when calling method: [nsIInterfaceRequestor::getInterface]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "<unknown>"  data: no]

i could not reproduce this error. mconnor, what's your STR?

Comment 1

[(not reading, please use [e-mail] instead)]

taking, per dietrich.

Comment 2

[(not reading, please use [e-mail] instead)]

for me, the add bookmark dialog does load, but I can not hit "OK".  or when I do, the dialog doesn't clear.

I get the following errors in the console:

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILAB
LE) [nsIAnnotationService.getAnnotationString]"  nsresult: "0x80040111 (NS_ERROR
_NOT_AVAILABLE)"  location: "JS frame :: file:///c:/builds/trunk-no-places/mozil
la/ff-debug/dist/bin/components/nsMicrosummaryService.js :: MSS__getField :: lin
e 662"  data: no]
************************************************************

Error: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIAnnotationService.getAnnotationString]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: file:///c:/builds/trunk-no-places/mozilla/ff-debug/dist/bin/components/nsMicrosummaryService.js :: MSS__getField :: line 662"  data: no]
Source File: file:///c:/builds/trunk-no-places/mozilla/ff-debug/dist/bin/components/nsMicrosummaryService.js
Line: 236

investigating...

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 4

[(not reading, please use [e-mail] instead)]

note, until we fix #373500, to fully test your microsummarized bookmarks, create them on the personal toolbar.

Comment 5

[Asaf Romano (gone)]

Comment on attachment 263394 [details] [diff] [review]
patch

r=mano.

Comment 6

[(not reading, please use [e-mail] instead)]

fixed.

Checking in nsMicrosummaryService.js;
/cvsroot/mozilla/browser/components/microsummaries/src/nsMicrosummaryService.js,
v  <--  nsMicrosummaryService.js
new revision: 1.62; previous revision: 1.61
done

Comment 7

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090128 Shiretoko/3.1b3pre. has been working for a long time.

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv