379007 - SeaMonkey specific files in /l10n repository

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[u162289]

Some files in /locale/editor/ui are not used in Thunderbird but only in SeaMonkey.
These files are mandatory to pass the compare-locales test and are unnecessary work for the locales that don't localize SeaMonkey.

Could these files be moved in a SeaMonkey specific dir?

I suppose this will require some changes in the Thunderbird Makefile : http://lxr.mozilla.org/mozilla/source/mail/locales/Makefile.in#105 and in the SeaMonkey build config : http://lxr.mozilla.org/mozilla/source/editor/ui/locales/jar.mn#39 and I probably forgot other files to modify.

Here are the files :

  ./editor/ui/chrome/dialogs/EditorSaveAsCharset.dtd
  ./editor/ui/chrome/dialogs/EditorImageMap.dtd
  ./editor/ui/chrome/dialogs/EditorPublishProgress.dtd
  ./editor/ui/chrome/dialogs/EditConflict.dtd
  ./editor/ui/chrome/dialogs/EditorSnapToGrid.dtd
  ./editor/ui/chrome/dialogs/EdLinkChecker.dtd
  ./editor/ui/chrome/dialogs/EditorImageMapHotSpot.dtd
  ./editor/ui/chrome/dialogs/EditorPageProperties.dtd
  ./editor/ui/chrome/dialogs/EditorPublish.dtd
  ./editor/ui/chrome/composer/pref-composer.dtd
  ./editor/ui/chrome/composer/editor.dtd
  ./editor/ui/chrome/composer/editorPrefsOverlay.dtd
  ./editor/ui/chrome/composer/pref-publish.dtd
  ./editor/ui/chrome/composer/pref-editing.dtd
  ./editor/ui/chrome/composer/pref-toolbars.dtd
  ./editor/ui/chrome/composer/editorNavigatorOverlay.dtd
  ./editor/ui/chrome/region/region.properties

Comment 1

[Axel Hecht [:Pike]]

Sounds like a great idea, Robert?

Comment 2

[Marek Stępień [:marcoos, inactive]]

Aren't these used (or planned to be used) by standalone Composer and Suiterunner? If so, it doesn't make much sense to move them out of editor...

Comment 3

[Axel Hecht [:Pike]]

For suiterunner, they could just as well be in suite/locales/en-US, really.

I'm not sure if composer wants them, wants all of them, in that way suiterunner does. And they could just have them in composer/locales/en-US, if they ever get that far.

Comment 4

[Robert Kaiser]

We aren't sure what to happen with composer in the long run as noone's actively working on it.
I feel a bit bad about shuffling locales files around in the tree just because the compare-locales logic sucks (I'm already no fan of the forked mailnews/ locale files), but I guess I could accept the suboptimal solution of moving them to suite/locales/en-US/chrome/editor/

Even though having content and locale files if seemingly independent base directories off mozilla/ always makes me shiver :(

Comment 5

[Wayne Mery (:wsmwk)]

Does this impact fluent?

Comment 6

[Magnus Melin [:mkmelin]]

I believe this is no longer relevant. Thunderbird no longer uses editor/ anything. The relevant dtds were copied over to mail/ (for all localizations too).