379515 - Importer (Win Eudora, Mail) Importing Windows Eudora mail is too slow

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoffrey C. Wenger]

Test importing of my work email takes over 6 hours (roughly 1.4 GB including attachments etc.). I've already come up with one way to speed it up - just needed an official spot to put the patch I've created.

Comment 1

[Geoffrey C. Wenger]

Attachment: Patch that fixes bug. Note patch was not created with CVS.

Comment 2

[Geoffrey C. Wenger]

Comment on attachment 263520 [details] [diff] [review]
 Patch that fixes bug. Note patch was not created with CVS.

Profiled importing email from Eudora (with GlowCode) and found a simple change that has sped up importing email over 5x (test importing of all my work email was taking 6.5 hours and now takes less than 1.2 hours).

Comment 3

[David :Bienvenu]

fixed on trunk, thx, Geoff.

Comment 4

[Scott MacGregor]

Comment on attachment 263520 [details] [diff] [review]
 Patch that fixes bug. Note patch was not created with CVS.

belatedly fixing the review flags since we landed this patch.

Comment 5

[Geoffrey C. Wenger]

Attachment: Trunk patch that fixes bugs in the modifications to my original patch. Also added one more small speed improvement change.

Patch application somehow went awry. It didn't accomplish intended speed up and accidentally introduced leaks. Fixed back to original intent. (Previous patch was not created with CVS which made application more difficult. This patch was created with CVS, which should make life easier.)

Also added small speed up to Eudora mail importing by calling SetDoFcc with PR_FALSE, which prevents some Fcc code from firing. Change made as a result of profiling.

Comment 6

[Scott MacGregor]

Comment on attachment 305093 [details] [diff] [review]
Trunk patch that fixes bugs in the modifications to my original patch. Also added one more small speed improvement change.

looks good to me.

Comment 7

[Reed Loden [:reed]]

Please open a new bug next time.

Checking in mailnews/import/eudora/src/nsEudoraCompose.cpp;
/cvsroot/mozilla/mailnews/import/eudora/src/nsEudoraCompose.cpp,v  <--  nsEudoraCompose.cpp
new revision: 1.78; previous revision: 1.77
done

Comment 8

[Geoffrey C. Wenger]

No problem Reed. Sorry I goofed with a batch of these. Thanks much for checking in.