379698 - Double accesskeys for same preference items

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.10) Gecko/20070313 Fedora/1.5.0.10-5.fc6 Firefox/1.5.0.10
Build Identifier: 

Thunderbird 2.0
The preference items in Advanced -> General (Wait [] seconds...) and in Composition -> General (Automatic save...) have double accesskeys, one for enabling the checkbox and the other controlling the nested textbox.
These are the only two items behaving this way.
My guess is to just remove the second accesskey and the control for the textbox, just as it is everywhere else.

Reproducible: Always

Comment 1

[Giacomo Magnini]

Attachment: Something like this...

Comment 2

[David :Bienvenu]

Comment on attachment 263706 [details] [diff] [review]
Something like this...

you need to ask review from a particular person - I'll put Scott, but perhaps Aaron Leventhal would be a better choice since accessibility is his focus.

Comment 3

[Scott MacGregor]

Giacomo, how do you get focus into the text box if it doesn't have an access key? One access key is for the check box, the other one is for the text box element.

Comment 4

[Giacomo Magnini]

Scott, I see the point, but is it really necessary? I mean, changing the value inside the textbox will require a click, but is less weird and confusing than having 2 accesskeys on the same line...
More, this will save a precious key for a valid accesskey (the bug about accesskeys being unique for every tab come to mind), especially thinking to l10n issues (for example, in it-IT we end up having weird accesskeys to avoid duplication, using illegible chars like l, i, g, etc.).
Please look also here: Advanced->Network & disk space-> "Compact folders...", which doesn't have 2 accesskeys, but has a textbox, too.
I'll not enlist SM pref panels, which are not relevant here (and not a single one has double accesskeys)
BTW, would it be possible to use the checkbox item to add control (as it seems to work with radioboxes)? That would "cut the bull's head" (literal translation of an Italian way of saying that actually means "settle the thing once and for all" ;) )
Adding Neil and Aaron, just in case. I'd really love to know which is right solution here.

Comment 5

[Scott MacGregor]

(In reply to comment #4)
> Scott, I see the point, but is it really necessary? I mean, changing the value
> inside the textbox will require a click

exactly, it would require a mouse click and that's why it needs an access key! :)

But I just looked at Firefox and Firefox does not use access keys for textboxes in the options dialog. See: Privacy / Hitory / [ ] Remember [v]isited pages for the last [  ] days.

It uses just one access key for the checkbox and then a tab to get to the text field. 

So maybe it's ok. We'll see what Aaron thinks.

Comment 6

[alexander :surkov (:asurkov)]

cc'ing david since he is around thunderbird ally.

Comment 7

[Giacomo Magnini]

(In reply to comment #5)
> exactly, it would require a mouse click and that's why it needs an access key!
> :)

As I wrote the message, I had the feeling this answer was coming... :-P

Comment 8

[Scott MacGregor]

Comment on attachment 263706 [details] [diff] [review]
Something like this...

This patch is consistent with what I see Firefox doing so I'm going to trust that they are doing the right thing so we can make our lives easier too and free up some access keys in the crowded pref tabs!

Comment 9

[Giacomo Magnini]

David, can you please check this in?
TIA, Giacomo.

Comment 10

[Mark Banner (:standard8)]

(In reply to comment #9)
> David, can you please check this in?
> TIA, Giacomo.
> 

I've checked this in on behalf of Giacomo.

Comment 11

[Giacomo Magnini]

Thank you, Mark!