380038 - add (un)selectRow/Column method for nsIAccessibleTable

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

1) add the following method nsIAccessibleTable
  selectRow/unselectRow/selectColumn/unselectColumn
2) implement fellow methods for IAccessibleTable

Comment 1

[alexander :surkov (:asurkov)]

Attachment: testcase

Comment 2

[Aaron Leventhal]

Comment on attachment 264096 [details] [diff] [review]
patch

Couldn't we save a good amount of code  by combining 
SelectRowOrColum and UnselectRowOrColumn and just adding PRBool aSelect as an argument?

If you decide to do it please request r? again and I'll do it quickly.

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch2

with Aaron's comment. If you see how to improve this then I'm happy to do it. Just I have a bit soaping sight and probably I miss something.

Comment 4

[Aaron Leventhal]

Comment on attachment 264114 [details] [diff] [review]
patch2

Roc is more of an sr= for layout/view stuff. Switching sr= request to Neil.

Comment 5

[Aaron Leventhal]

Comment on attachment 264114 [details] [diff] [review]
patch2

Looks good to me.

Roc is more of an sr= for layout/view stuff. Switching sr= request to Neil.

Comment 6

[[e-mail]]

Comment on attachment 264114 [details] [diff] [review]
patch2

>+    PRInt32 column  = doSelectRow ? index : aIndex;
Nit: two spaces between column and =

>+  nsresult rv = selection2->GetRangesForIntervalCOMArray(parent, offset,
>+                                                         parent, offset,
I don't know this API but doesn't that represent an empty range?

Comment 7

[alexander :surkov (:asurkov)]

(In reply to comment #6)

> >+  nsresult rv = selection2->GetRangesForIntervalCOMArray(parent, offset,
> >+                                                         parent, offset,
> I don't know this API but doesn't that represent an empty range?
> 

No, third argument points that returned ranges may be greater than given start and end. And at least it works :)

Comment 8

[[e-mail]]

Comment on attachment 264114 [details] [diff] [review]
patch2

I see now, you're removing all ranges containing or contained by that cell.

Comment 9

[[e-mail]]

(In reply to comment #8)
>(From update of attachment 264114 [details] [diff] [review])
>I see now, you're removing all ranges containing or contained by that cell.
No, in fact, only those ranges containing that cell.

Comment 10

[alexander :surkov (:asurkov)]

checked in