380116 - [FIX]"Wrong parent style context" involving table { display: block } and <select>

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase in a debug build causes this console output:

frame: Text(-1) (0x3f39cd58) style: 0x3f26c9d8 :-moz-non-element {}
Wrong parent style context:  style: 0x3f26caf8 :-moz-display-comboboxcontrol-frame {}
should be using:  style: 0x3f18aa98 {}

frame: Text(-1) (0x3f18b1c0) style: 0x3f1a1fb4 :-moz-non-element {}
Wrong parent style context:  style: 0x3f1a1d08 :-moz-button-content {}
should be using:  style: 0x3f18ade4 {}

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Use the same style context parents as a reresolve will pick up

Comment 2

[Boris Zbarsky [:bzbarsky]]

Not sure how to test this...

Comment 3

[Jesse Ruderman]

Toss it in a random test suite and make "wrong parent style context" an assertion? ;)

Comment 4

[Boris Zbarsky [:bzbarsky]]

That might work...

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 264217 [details] [diff] [review]
Use the same style context parents as a reresolve will pick up

Rubber-stamp r+sr=dbaron

Comment 6

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 7

[Jesse Ruderman]

Crashtest checked in.  "Wrong parent style context" is now an assertion, so once assertions turn Tinderbox orange, this will be properly regression-tested.