380439 - vertical-align inherits percentages rather than computed value

Status: NEW

(Core :: CSS Parsing and Computation, defect)

Description

[fantasai]

Attachment: testcase

Overview:

  CSS2.1 specifies that percentages in vertical-align inherit as absolute
  lengths, not as percentages. We inherit as a percentage.
    http://www.w3.org/TR/CSS21/visudet.html#propdef-vertical-align

Steps to Reproduce:

  Open up testcase in Mozilla

Actual Results:

  Inner <span> in second test does not move up the same amount as
  the outer <span>.

Expected Results;

  Both tests should render identically.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

To fix this, we need to:
 * compute percentages on mVerticalAlign in nsRuleNode (which requires setting inherited = PR_TRUE if it depends on things in other style structs) into lengths
 * change the comment in nsStyleStruct.h to say mVerticalAlign can't be a percentage nsStyleCoord
 * remove the handling of percentage mVerticalAlign nsStyleCoords elsewhere