93865 - vertical-align cannot inherit percentages

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P4)

Description

[fantasai]

Overview:

	Explicit inheritance of percentage values for 'vertical-align' does not
	work, although explit inheritance of pixel values does.

Steps to Reproduce:

	Open up testcase in Mozilla

Actual Results:

	Inner <span> in second test remains at the baseline.

Expected Results;

	Both tests should render identically.

Tested on Mozilla nightly build (id: 2001080203) on Windows 2000

Additional Comments:

	Bug 91054 might cause incorrect rendering of the testcase after a fix.

Comment 1

[fantasai]

Attachment: testcase

Comment 2

[Pierre Saslawsky]

Marking dependencies on related bugs, just for the record.

Comment 3

[Hixie (not reading bugmail)]

Does the spec say percentages should inherit as percentages? Shouldn't they
inherit as the device-native length (pixels)? Inheritance works on computed
values, not specified values.

Comment 4

[fantasai]

Yes, the spec says it should inherit the computed value. 
My point is that percentages are not inheriting _at all_.

Comment 5

[Kevin McCluskey (gone)]

Moving to mozilla1.1. Engineers are overloaded!

Comment 6

[Kevin McCluskey (gone)]

Bulk moving from Moz1.1 to future-P1. I will pull from this list when scheduling
work post Mozilla1.0.

Comment 7

[Madhur Bhatia]

cc'ing myself

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Assigning pierre's remaining Style System-related bugs to myself.

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Mostly fixed by bug 205790, but I'm not sure if we're inheriting them correctly.
 fantasai also points out that the spec may not make sense...

Comment 10

[Hixie (not reading bugmail)]

Could you expand on that? I can't add vague statements to the issues-cr list. :-)

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

"Should the computed value for percentage values of 'vertical-align' be the
percentage or the absolute length to which it computes?"

Comment 12

[fantasai]

Marking fixed. Probably was fixed during the computed value rehaul awhile back.

Comment 13

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Would you mind spinning off inheriting percentages correctly into its own bug before marking this as fixed?

Comment 14

[fantasai]

bug 380439 filed.