380689 - Import/Export separators titles

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

Import/Export of separators titles.

It's not yet clear whether we're going to have UI for this feature in Places, but per discussion with mconnor we're going to put import/export support for that in place, at least for the time being.

Comment 1

[(not reading, please use [e-mail] instead)]

fwiw, I vaguely remember Dietrich saying that Todd used separator titles in fx 2 for sync with foxmarks.

Comment 2

[Asaf Romano (gone)]

Attachment: patch

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 264818 [details] [diff] [review]
patch

r=sspitzer, 

1)

//    "<HR>"

should we elaborate the comment to include that you might see:

// "<HR NAME="...">"

2) any reason why nsPlacesImportExportService::WriteSeparator() shouldn't take a PRInt64 aId as the first param, instead of a nsINavHistoryResultNode?

Comment 4

[Asaf Romano (gone)]

1) sure, done.
2) * consistency with WriteItem
   * we don't have the itemId handy in the caller
   * I would like to change this code to use node->GetTitle if we keep this
     functionality.

Comment 5

[Asaf Romano (gone)]

Attachment: as checked in

mozilla/browser/components/places/src/nsPlacesImportExportService.cpp 1.8
mozilla/browser/components/places/src/nsPlacesImportExportService.h 1.4

Comment 6

[Todd Agulnick]

(In reply to comment #1)
> fwiw, I vaguely remember Dietrich saying that Todd used separator titles in fx
> 2 for sync with foxmarks.
> 

Just for the record:

I suspect that you're referring to an observation I made a year ago that the then-proposed data model for Places didn't allow a separator to have a name/title, in contrast to the current RDF data model of fx 1/2.

Foxmarks doesn't need them per se (though it does sync 'em). Names on separators are a little-known feature, but I don't think we shouldn't dump them unintentionally.

Dumping them intentionally, on the other hand, would probably be okay.

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv