Closed Bug 380895 Opened 17 years ago Closed 17 years ago

Clean up missing or unnecessary files in packages-static

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philor, Assigned: philor)

References

()

Details

(Keywords: fixed1.8.1.5)

Attachments

(2 files)

cf says the spew of "Warning: package error or possible missing or unnecessary file:" is bad enough to be annoying in the release process (and is certainly annoying when you're looking at a Tinderbox "Brief log" trying to find something real in the midst of 87 meaningless lines).
Attached patch Trunk v.1Splinter Review
Removed things:

-bin\components\helperAppDlg.xpt
   actually found in exthandler.xpt

-bin\components\intlcmpt.xpt
   removed in bug 352180

-bin\components\jsurl.xpt
   removed in bug 277371

-bin\components\necko_jar.xpt
   removed by bug 248044, re-added by aviary-landing

-bin\components\prefmigr.xpt
   only built ifndef MOZ_SINGLE_PROFILE

-bin\components\related.xpt
-bin\components\search.xpt
   only built for MOZ_SUITE

-bin\components\util.xpt
   created by landing of packaging branch, 2004-01-06 17:22, disappeared when nsITimeRecorder.idl was removed 2004-01-07 14:30

-bin\res\platform-forms.css
   removed by bug 272151

-bin\gksvggdiplus.dll
   --enable-svg-renderer=gdiplus isn't supported on the trunk

-bin\res\svg.properties
   removed from /res/ by bug 296169

-bin\chrome\pipnss.jar
   only contains a contents.rdf we don't build

Missing things we have to live with:

bin/xul.dll
  only built with --enable-libxul
bin/components/bookmarks.xpt
bin/components/nsBookmarkTransactionManager.js
  only built for non-places-bookmarks
bin/components/ucnative.xpt
  only built with --enable-native-uconv
bin/defaults/existing-profile-defaults.js
  used in the confusing changing of defaults process

Things I'm not sure about, so I left them:

bin/components/wallet.xpt
bin/components/walleteditor.xpt
bin/components/walletpreview.xpt
bin/components/signonviewer.xpt
  you certainly can build Fx with wallet, most likely with extensions=all, dunno if it would work, or how to tell
Attachment #265435 - Flags: review?(benjamin)
Attachment #265435 - Flags: review?(benjamin) → review+
browser/installer/windows/packages-static 1.111
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Attached patch Branch v.1Splinter Review
1.8 branch version, same reasons, just not quite as many (and, sadly, not including places.xpt, since nobody got around to erroring out of configure for --enable-places).
Attachment #266167 - Flags: review?(benjamin)
Attachment #266167 - Flags: review?(benjamin) → review+
Attachment #266167 - Flags: approval1.8.1.5?
Comment on attachment 266167 [details] [diff] [review]
Branch v.1

approved for 1.8.1.5, a=dveditz for release-drivers
Attachment #266167 - Flags: approval1.8.1.5? → approval1.8.1.5+
browser/installer/windows/packages-static 1.53.2.39
Keywords: fixed1.8.1.5
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: