380904 - Don't ship Georgian on the Mac

Status: RESOLVED FIXED

(Mozilla Localizations :: ka / Georgian, defect)

Description

[Axel Hecht [:Pike]]

We found layout problems with Georgian on the Mac, rendering the localization unusable on that platform.

We should change the entry in shipped-locales to specify just win32 and linux.

Comment 1

[Axel Hecht [:Pike]]

Attachment: ship Georgian only on win32 and linux

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 265021 [details] [diff] [review]
ship Georgian only on win32 and linux

We decided not to take this change. Georgian will stay as a beta locale for 2.0.0.4

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 265021 [details] [diff] [review]
ship Georgian only on win32 and linux

Actually, I'd rather have an r+ on this patch. Rerequesting.

But yes, we decided to not take this for .4. Gia, we could have checked this earlier, if we had known that you had no mac testing at all.

This is a layout issue, so nothing you can fix, really. We'll just not ship mac builds, but at this point, we can only take that change for the next release.

Requesting approval for this patch for .5 already.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 265021 [details] [diff] [review]
ship Georgian only on win32 and linux

Duh, sorry about that. r=cf

Comment 5

[J. Paul Reed [:preed]]

(In reply to comment #3)
> (From update of attachment 265021 [details] [diff] [review])
> Actually, I'd rather have an r+ on this patch. Rerequesting.
> 
> But yes, we decided to not take this for .4. Gia, we could have checked this
> earlier, if we had known that you had no mac testing at all.
> 
> This is a layout issue, so nothing you can fix, really. We'll just not ship mac
> builds, but at this point, we can only take that change for the next release.

So I talked to Juan about this; just so there's no confusion, if we're not taking the code change to shipped-locales, then the mac build will show up on th ftp site.

We can brand/communicate it on the website however we want ("Win32/Linux is released, mac is still in beta," etc.), but if we're talking about pulling the mac builds from ftp, then we'll need to take this shipped-locales change, which would require an rc4 (we wouldn't respin any builds, but we would respin the source tarball, etc.)

Comment 6

[Axel Hecht [:Pike]]

The builds have been on ftp for 2.0.0.2 and 2.0.0.3, I'm not worried about having them there on 2.0.0.4, at least not enough for us having to do an rc4.

I'd not like to have them on the webpage, and it might be a good idea to pull them from the release notes. Reed, could you help on that? Or is that strictly Basil?

Comment 7

[Reed Loden [:reed]]

(In reply to comment #6)
> The builds have been on ftp for 2.0.0.2 and 2.0.0.3, I'm not worried about
> having them there on 2.0.0.4, at least not enough for us having to do an rc4.
> 
> I'd not like to have them on the webpage, and it might be a good idea to pull
> them from the release notes. Reed, could you help on that? Or is that strictly
> Basil?

I never know who is doing release notes anymore... I'd rather have the appropriate person do it. Baz: Who is that? ;)

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 265021 [details] [diff] [review]
ship Georgian only on win32 and linux

self-approving change to not ship Georgian on the mac, as layout is broken there.

Comment 9

[Axel Hecht [:Pike]]

Landed. Nick, any suggestion on how we verify this bug?

Checking in shipped-locales;
/cvsroot/mozilla/browser/locales/Attic/shipped-locales,v  <--  shipped-locales
new revision: 1.1.4.17; previous revision: 1.1.4.16
done

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Axel, not so easy to verify this early in the game, other than the simple check on CVS. 

Once the next release cycle starts there wouldn't be an update for Mac from 2.0.0.4. And we should check after grooming the files for the release (grooming is the gatekeeper script that only includes locales & platforms in shipped-locales). Famous last words, but it should all happen automatically now.