Remove old password manager .idl and .h files

RESOLVED FIXED in mozilla1.9.3a1

Status

()

defect
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: Dolske, Assigned: Dolske)

Tracking

Trunk
mozilla1.9.3a1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
The conversion of the toolkit login manager to JS (bug 374723) made a number of old password manager interfaces obsolete. However, they're still in use by wallet users, such as SeaMonkey. So, they've been left in place until SeaMonkey can finish transitioning to Toolkit (and the toolkit login manager). Once that's done, the old files should be removed.

netwerk/base/public/nsCPasswordManager.h
netwerk/base/public/nsCPasswordManagerInternal.h
netwerk/base/public/nsIPasswordManager.idl
netwerk/base/public/nsIPasswordManagerInternal.idl
netwerk/base/public/nsIPasswordManagerUtils.h
(Assignee)

Updated

12 years ago
Depends on: 304309

Updated

12 years ago
Depends on: 239131

Updated

12 years ago
Depends on: 390025
(Assignee)

Comment 1

12 years ago
Also, any instances of "@mozilla.org/passwordmanager/authpromptfactory;1" should be switched to ""@mozilla.org/login-manager/authpromptfactory;1".
(Assignee)

Comment 2

12 years ago
And... The changes in bug 396316 change the code originally based on NS_GetAuthHostPort / NS_GetAuthKey in promptUtils.h, so that code should be removed too.
Product: Firefox → Toolkit
(Assignee)

Updated

11 years ago
Depends on: 454284

Comment 3

11 years ago
I think this can moved forward when time allows, as Thunderbird and SeaMonkey now have switched away from wallet and so only the new toolkit login manager is used by 1.9.1-based apps now.
(Assignee)

Comment 4

10 years ago
Posted patch Patch v.1 (interface removal) (obsolete) — Splinter Review
This removes the interfaces mentiond in comment 0. I don't think the change in comment 1 is worth doing now, and I'll do the code changed from comment 2 in a separate patch.

There are actually still a couple references to these interfaces in the tree, but I think they're ok:

1) /testing/extensions/community/chrome/content/prefs.js has backwards-compatibility support for FF2.

2) /modules/plugin/os2wrapper/moz_IDs_Input.lst already seems to have some obsolete references, so it's probably ok. Not really sure what this does or if it should be updated, though.
Assignee: nobody → dolske
Attachment #361202 - Flags: review?(gavin.sharp)
(Assignee)

Comment 5

10 years ago
Peter, you'd probably know about the last part of comment 4?
(Assignee)

Comment 6

10 years ago
Hmm, actually, given the pit-of-despair that is nsPrompt and the indirect relation with the old password manager, I'll just leave the comment 2 cleanup for the hazy future.

Comment 7

10 years ago
Justin, thanks for asking. That file is used to create moz_IDs_Generated.h (which in turn is used in the os2wrapper "magic" so that certain OS/2 plugins continue to work). If you remove interfaces they should be removed from that list, too.
(Assignee)

Comment 8

10 years ago
Peter, should I worry that the new nsILoginMananger interfaces are not in that file? Or is it basically just a backwards compatibility thing that doesn't need new interfaces added?

Comment 9

10 years ago
Justin, no, that should be OK. I think we only need a new interface listed, if an old one whose functions we use in wrap_XPCOM.cpp is replaced.
(Assignee)

Comment 10

10 years ago
Posted patch Patch v.2Splinter Review
Also cleans up OS/2 bits, per previous comments.
Attachment #361202 - Attachment is obsolete: true
Attachment #362618 - Flags: review?(gavin.sharp)
Attachment #361202 - Flags: review?(gavin.sharp)
Attachment #362618 - Attachment is patch: true
Attachment #362618 - Attachment mime type: application/octet-stream → text/plain
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Updated

10 years ago
Attachment #362618 - Flags: review?(gavin.sharp) → review?(mconnor)
Attachment #362618 - Flags: review?(mconnor) → review+
(Assignee)

Comment 11

10 years ago
Pushed http://hg.mozilla.org/mozilla-central/rev/63fa8ef70994
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Depends on: 511797
You need to log in before you can comment on or make changes to this bug.