380917 - Remove old password manager .idl and .h files

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Justin Dolske [:Dolske]]

The conversion of the toolkit login manager to JS (bug 374723) made a number of old password manager interfaces obsolete. However, they're still in use by wallet users, such as SeaMonkey. So, they've been left in place until SeaMonkey can finish transitioning to Toolkit (and the toolkit login manager). Once that's done, the old files should be removed.

netwerk/base/public/nsCPasswordManager.h
netwerk/base/public/nsCPasswordManagerInternal.h
netwerk/base/public/nsIPasswordManager.idl
netwerk/base/public/nsIPasswordManagerInternal.idl
netwerk/base/public/nsIPasswordManagerUtils.h

Comment 1

[Justin Dolske [:Dolske]]

Also, any instances of "@mozilla.org/passwordmanager/authpromptfactory;1" should be switched to ""@mozilla.org/login-manager/authpromptfactory;1".

Comment 2

[Justin Dolske [:Dolske]]

And... The changes in bug 396316 change the code originally based on NS_GetAuthHostPort / NS_GetAuthKey in promptUtils.h, so that code should be removed too.

Comment 3

[Robert Kaiser]

I think this can moved forward when time allows, as Thunderbird and SeaMonkey now have switched away from wallet and so only the new toolkit login manager is used by 1.9.1-based apps now.

Comment 4

[Justin Dolske [:Dolske]]

Attachment: Patch v.1 (interface removal)

This removes the interfaces mentiond in comment 0. I don't think the change in comment 1 is worth doing now, and I'll do the code changed from comment 2 in a separate patch.

There are actually still a couple references to these interfaces in the tree, but I think they're ok:

1) /testing/extensions/community/chrome/content/prefs.js has backwards-compatibility support for FF2.

2) /modules/plugin/os2wrapper/moz_IDs_Input.lst already seems to have some obsolete references, so it's probably ok. Not really sure what this does or if it should be updated, though.

Comment 5

[Justin Dolske [:Dolske]]

Peter, you'd probably know about the last part of comment 4?

Comment 6

[Justin Dolske [:Dolske]]

Hmm, actually, given the pit-of-despair that is nsPrompt and the indirect relation with the old password manager, I'll just leave the comment 2 cleanup for the hazy future.

Comment 7

[Peter Weilbacher]

Justin, thanks for asking. That file is used to create moz_IDs_Generated.h (which in turn is used in the os2wrapper "magic" so that certain OS/2 plugins continue to work). If you remove interfaces they should be removed from that list, too.

Comment 8

[Justin Dolske [:Dolske]]

Peter, should I worry that the new nsILoginMananger interfaces are not in that file? Or is it basically just a backwards compatibility thing that doesn't need new interfaces added?

Comment 9

[Peter Weilbacher]

Justin, no, that should be OK. I think we only need a new interface listed, if an old one whose functions we use in wrap_XPCOM.cpp is replaced.

Comment 10

[Justin Dolske [:Dolske]]

Attachment: Patch v.2

Also cleans up OS/2 bits, per previous comments.

Comment 11

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/63fa8ef70994