Closed
Bug 454284
Opened 18 years ago
Closed 18 years ago
Remove EmbedPasswordMgr.cpp from mozilla-central
Categories
(Core Graveyard :: Embedding: GRE Core, defect)
Core Graveyard
Embedding: GRE Core
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1b1
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(1 file)
|
93.04 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
This code forked from the old C++ password manager in the past. It's now unmaintained and incompatible with the current Toolkit password manager. There are likely security issues in it, since it's never been updated. We should remove it from the tree.
|
Assignee | |
Comment 2•18 years ago
|
||
Assignee: nobody → dolske
|
|
Assignee | |
Comment 3•18 years ago
|
||
Comment on attachment 337706 [details] [diff] [review]
Patch v.1
Tested on my Linux box by doing a build and checking that TestGtkEmbed still brings up a browser.
[Timeless clarified on IRC that his comment 1 is saying removing this code is ok.]
Attachment #337706 -
Flags: review?(benjamin)
|
||
Updated•18 years ago
|
Attachment #337706 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 4•18 years ago
|
||
Pushed changeset badc65a93bd9.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
|
||
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•