380958 - Strict Warning: PC_setBookmarksToolbarFolder does not always return a value

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Shawn Wilsher :sdwilsh]

I didn't find an existing bug, so here's hoping it isn't a dupe.  This is from the nightly:

Warning: function PC_setBookmarksToolbarFolder does not always return a value
Source File: chrome://browser/content/places/controller.js
Line: 893, Column: 2
Source Code:
  },

Comment 1

[Steve Won (stevewon on irc)]

Attachment: Patch to fix the bug

Comment 2

[Dietrich Ayala (:dietrich)]

thanks steve. a couple of changes:

1. please use spaces instead of tabs (see http://developer.mozilla.org/en/docs/JavaScript_style_guide for that and other guidelines)

2. please indent lined up with the line above your change

Comment 3

[Steve Won (stevewon on irc)]

Attachment: Patch modified

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 265181 [details] [diff] [review]
Patch modified

looks good, thanks :)

Comment 5

[Shawn Wilsher :sdwilsh]

This was fixed by Bug 381335 before it got checked in.

Comment 6

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a7pre) Gecko/2007070504 Minefield/3.0a7pre

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv