The default bug view has changed. See this FAQ.

make JS1.8 the default for <xul:script>

RESOLVED FIXED in mozilla1.9alpha6

Status

()

Core
XUL
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Nickolay_Ponomarev, Assigned: Nickolay_Ponomarev)

Tracking

({dev-doc-complete})

Trunk
mozilla1.9alpha6
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9 -
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

10 years ago
From bug 380236 comment 7:

Mike Shaver   2007-05-10 05:32:08 PDT

Related (I think): can/should we make JS1.8 the default for XUL-loaded JS in
Gecko 1.9?  We didn't in 1.8.1 for good compatibility reasons, but it makes for
a lot of poking around by extension and app authors to get the right versioning
parameters, and I think we'd do better by them in 1.9 to make the switch.
Flags: blocking1.9?
(Assignee)

Updated

10 years ago
Summary: make JS1.8 the default for XUL-loaded JS → make JS1.8 the default for <xul:script>
(Assignee)

Updated

10 years ago
Duplicate of this bug: 381618
Flags: blocking1.9? → blocking1.9-
(Assignee)

Comment 2

10 years ago
Created attachment 266300 [details] [diff] [review]
patch

(Depends on bug 382182.)

I dislike how it duplicates the version constant from the JS_SetVersion call here: http://mxr.mozilla.org/seamonkey/source/js/src/xpconnect/loader/mozJSComponentLoader.cpp#514

Would it be better to add a JSVERSION_LATEST value to the JSVersion enum?
Attachment #266300 - Flags: review?(brendan)
(Assignee)

Updated

10 years ago
Depends on: 382182
Yes, JSVERSION_LATEST -- just do it in this bug.

/be
Nickolay: ping? I can approve that patch but would rather see JSVERSION_LATEST, unless you prefer to do it in a separate bug.

/be
(Assignee)

Comment 5

10 years ago
Sorry, didn't have the time near my dev machine lately. I'll post an updated patch  tonight or tomorrow.
(Assignee)

Comment 6

10 years ago
Created attachment 267630 [details] [diff] [review]
patch with JSVERSION_LATEST

Better late than never!
Assignee: nobody → asqueella
Attachment #266300 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #267630 - Flags: review?(brendan)
Attachment #266300 - Flags: review?(brendan)
Comment on attachment 267630 [details] [diff] [review]
patch with JSVERSION_LATEST


>             rv = mimeHdrParser->GetParameter(typeAndParams, "version",
>                                              EmptyCString(), PR_FALSE, nsnull,
>                                              versionName);
>             if (NS_FAILED(rv)) {
[snip]
>+              // no version specified - version remains the default.
>+              if (rv != NS_ERROR_INVALID_ARG)
>+                return rv;

Since you fixed indentation here, could you also move the "no version specified ..." comment to after the if-early-return, which is exclusive of the comment's sense?

r+sr=me with that, thanks.

/be
Attachment #267630 - Flags: superreview+
Attachment #267630 - Flags: review?(brendan)
Attachment #267630 - Flags: review+
(Assignee)

Comment 8

10 years ago
Created attachment 267642 [details] [diff] [review]
with the nit fixed
Attachment #267630 - Attachment is obsolete: true
mozilla/content/xul/document/src/nsXULContentSink.cpp 	1.183
mozilla/js/src/jspubtd.h 	3.84
mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp 	1.136
mozilla/extensions/jssh/nsJSSh.cpp 	1.11
(Assignee)

Comment 10

10 years ago
Brendan, thanks for the quick reviews.

Gavin, thanks for the checkin.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha6
(Assignee)

Updated

10 years ago
Blocks: 385159
(Assignee)

Comment 11

10 years ago
dev-doc-complete: Mentioned on http://developer.mozilla.org/en/docs/Firefox_3_for_developers
Keywords: dev-doc-complete

Updated

9 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.