Last Comment Bug 382182 - script tag should support version 1.8
: script tag should support version 1.8
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: ---
Assigned To: Bob Clary [:bc:]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks: js1.8 381031
  Show dependency treegraph
 
Reported: 2007-05-27 15:30 PDT by Bob Clary [:bc:]
Modified: 2007-05-29 22:56 PDT (History)
4 users (show)
bob: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1 (2.88 KB, text/plain)
2007-05-27 15:30 PDT, Bob Clary [:bc:]
jonas: review+
brendan: superreview+
Details

Description Bob Clary [:bc:] 2007-05-27 15:30:12 PDT
Created attachment 266292 [details]
patch v1
Comment 1 Nickolay_Ponomarev 2007-05-28 10:34:41 PDT
Should the version number at http://mxr.mozilla.org/seamonkey/source/js/src/xpconnect/loader/mozJSComponentLoader.cpp#514 be updated as well?
Comment 2 Bob Clary [:bc:] 2007-05-28 11:31:40 PDT
(In reply to comment #1)
> Should the version number at
> http://mxr.mozilla.org/seamonkey/source/js/src/xpconnect/loader/mozJSComponentLoader.cpp#514
> be updated as well?
> 

I'll leave that up to others. Another place where it might be of concern is in jssh <http://lxr.mozilla.org/mozilla/source/extensions/jssh/nsJSSh.cpp#593>.
Comment 3 Jonas Sicking (:sicking) No longer reading bugmail consistently 2007-05-28 18:34:06 PDT
Comment on attachment 266292 [details]
patch v1

Would like to get brendan to ok this one too.
Comment 4 Brendan Eich [:brendan] 2007-05-29 21:40:45 PDT
Comment on attachment 266292 [details]
patch v1

sr=me, no need for jst.

Nickolay, please feel free to file bugs on

/js/src/xpconnect/loader/mozJSComponentLoader.cpp, line 515 -- JS_SetVersion(mContext, JSVERSION_1_7);
/extensions/jssh/nsJSSh.cpp, line 593 -- JS_SetVersion(mJSContext, JSVERSION_1_7);

and your JSVERSION_LATEST is a good idea -- that can be done at the same time, or in a blocking bug. I want to r+ this for 1.9a5 ASAP, otherwise it could depend on JSVERSION_LATEST too. Thanks,

/be
Comment 5 Bob Clary [:bc:] 2007-05-29 22:56:39 PDT
Checking in content/base/src/nsParserUtils.cpp;t.cpp js/src/jsapi.c js/src/jspub/cvsroot/mozilla/content/base/src/nsParserUtils.cpp,v  <--  nsParserUtils.cpp
new revision: 1.22; previous revision: 1.21
done
Checking in dom/src/base/nsJSEnvironment.cpp;
/cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v  <--  nsJSEnvironment.cpp
new revision: 1.325; previous revision: 1.324
done
Checking in js/src/jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.323; previous revision: 3.322
done
Checking in js/src/jspubtd.h;
/cvsroot/mozilla/js/src/jspubtd.h,v  <--  jspubtd.h
new revision: 3.83; previous revision: 3.82
done

Note You need to log in before you can comment on or make changes to this bug.