The default bug view has changed. See this FAQ.

script tag should support version 1.8

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: bc, Assigned: bc)

Tracking

Trunk
x86
All
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.88 KB, text/plain
sicking
: review+
brendan
: superreview+
Details
(Assignee)

Description

10 years ago
Created attachment 266292 [details]
patch v1
Flags: in-testsuite-
Flags: blocking1.9?
Attachment #266292 - Flags: review?(brendan)
(Assignee)

Updated

10 years ago
Attachment #266292 - Flags: superreview?(jst)
Attachment #266292 - Flags: review?(jonas)

Comment 1

10 years ago
Should the version number at http://mxr.mozilla.org/seamonkey/source/js/src/xpconnect/loader/mozJSComponentLoader.cpp#514 be updated as well?
Blocks: 381031
(Assignee)

Comment 2

10 years ago
(In reply to comment #1)
> Should the version number at
> http://mxr.mozilla.org/seamonkey/source/js/src/xpconnect/loader/mozJSComponentLoader.cpp#514
> be updated as well?
> 

I'll leave that up to others. Another place where it might be of concern is in jssh <http://lxr.mozilla.org/mozilla/source/extensions/jssh/nsJSSh.cpp#593>.
Comment on attachment 266292 [details]
patch v1

Would like to get brendan to ok this one too.
Attachment #266292 - Flags: review?(jonas) → review+
Comment on attachment 266292 [details]
patch v1

sr=me, no need for jst.

Nickolay, please feel free to file bugs on

/js/src/xpconnect/loader/mozJSComponentLoader.cpp, line 515 -- JS_SetVersion(mContext, JSVERSION_1_7);
/extensions/jssh/nsJSSh.cpp, line 593 -- JS_SetVersion(mJSContext, JSVERSION_1_7);

and your JSVERSION_LATEST is a good idea -- that can be done at the same time, or in a blocking bug. I want to r+ this for 1.9a5 ASAP, otherwise it could depend on JSVERSION_LATEST too. Thanks,

/be
Attachment #266292 - Flags: superreview?(jst)
Attachment #266292 - Flags: superreview+
Attachment #266292 - Flags: review?(brendan)
(Assignee)

Comment 5

10 years ago
Checking in content/base/src/nsParserUtils.cpp;t.cpp js/src/jsapi.c js/src/jspub/cvsroot/mozilla/content/base/src/nsParserUtils.cpp,v  <--  nsParserUtils.cpp
new revision: 1.22; previous revision: 1.21
done
Checking in dom/src/base/nsJSEnvironment.cpp;
/cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v  <--  nsJSEnvironment.cpp
new revision: 1.325; previous revision: 1.324
done
Checking in js/src/jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.323; previous revision: 3.322
done
Checking in js/src/jspubtd.h;
/cvsroot/mozilla/js/src/jspubtd.h,v  <--  jspubtd.h
new revision: 3.83; previous revision: 3.82
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Flags: blocking1.9?
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.