381052 - Customize of Navbar causes bookmarks on Bookmarks bar to disappear

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a5pre) Gecko/20070517 Minefield/3.0a5pre Firefox/3.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a5pre) Gecko/20070517 Minefield/3.0a5pre Firefox/3.0

Right-click and choose 'customize' on the Navbar.  Close the 'customize' window with done, note that the Bookmarks on the Boookmarks Toolbar disappear.  They will reappear when you close/restart Firefox. 

This seems to occur on today's Places Experimental build.  Do not have a regression range yet. 

Reproducible: Always

Steps to Reproduce:
1.  Right-click on Navbar - choose customize
2.  Close the Diaglog box with 'done' in the customize window
3.  Note that the bookmarks on the Bookmarks Toolbar are missing.
Actual Results:  
Bookmarks on the Bookmarks bar disappear until you close/restart Minefield.

Expected Results:  
Bookmarks should not disappear. 

Places Experimental build on Vista HP

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a5pre) Gecko/20070517 Minefield/3.0a5pre Firefox/3.0 ID:2007051703 [cairo]

Comment 1

[bomfog]

Same here, on win Server 2003, fresh profile. On an older profile, an empty folder I had on the left end of the bm toolbar was left behind. Also don't know range, but I *believe* I saw this yesterday (16 may) or earlier.

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a5pre) Gecko/20070517 Minefield/3.0a5pre - Build ID: 2007051706

Comment 2

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070517 Minefield/3.0a5pre

I see this too and it sounds very familiar to me.

Comment 3

[Dietrich Ayala (:dietrich)]

in a debug build, i see this error when closing the customize dialog:

###!!! ASSERTION: failed to get the nsIScriptGlobalObject. bug 95465?: 'boundGlobal', file /Users/dayala/moz/newplaces/mozilla/content/xbl/src/nsXBLPrototypeHandler.cpp, line 462

Comment 4

[Asaf Romano (gone)]

Blocks Fx3, but not places-bookmarks in general.

Comment 5

[Asaf Romano (gone)]

Attachment: patch

Just so you know, cust sucks, it really does.

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 265146 [details] [diff] [review]
patch

r=sspitzer

Comment 7

[Asaf Romano (gone)]

mozilla/browser/base/content/browser.js 1.786

Comment 8

[Al Billings [:abillings - ex-MoCo]]

Verified in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707270404 Minefield/3.0a7pre.

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv