Closed
Bug 381174
Opened 17 years ago
Closed 17 years ago
locale not exposed for document frame
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: scott, Assigned: aaronlev)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(2 files, 2 obsolete files)
|
8.85 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
|
1.14 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
The locale is not exposed for the document frame node. Please note http://lxr.mozilla.org/seamonkey/source/accessible/src/atk/nsMaiInterfaceDocument.cpp#55
|
Assignee | |
Comment 1•17 years ago
|
||
|
|
Assignee | |
Comment 2•17 years ago
|
||
|
|
Assignee | |
Updated•17 years ago
|
Attachment #265339 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•17 years ago
|
||
Comment on attachment 265589 [details] [diff] [review]
Works correctly if content-language is set properly.
Test on www.hallo.de and it reports "de".
On pages that don't set the content-language you'd have to assume it's the same locale as the system, I guess.
Attachment #265589 -
Attachment description: For some reason I keep getting an empty string from |doc->GetHeaderData(nsAccessibilityAtoms::headerContentLanguage, locale);| → Works correctly if content-language is set properly.
Attachment #265589 -
Flags: review?(surkov.alexander)
|
|
Assignee | |
Updated•17 years ago
|
Attachment #265589 -
Attachment is obsolete: true
Attachment #265589 -
Flags: review?(surkov.alexander)
|
|
Assignee | |
Comment 4•17 years ago
|
||
1) Try on <body>
2) Try on <html>
3) Try content-language
4) If we don't know the language we'll return NULL
Attachment #265609 -
Flags: review?(surkov.alexander)
|
||
Comment 5•17 years ago
|
||
Comment on attachment 265609 [details] [diff] [review]
The best we can get -- many pages don't indicate what language they're in
>+ if (!content ) {
nit: please remove space
Attachment #265609 -
Flags: review?(surkov.alexander) → review+
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 6•17 years ago
|
||
aaronlev, this was checked in as a bustage fix. Can you please OK this?
|
|
||
Comment 7•17 years ago
|
||
Comment on attachment 265765 [details] [diff] [review]
bustage fix
Sorry, I missed this. Thank your for the fix.
Attachment #265765 -
Flags: review+
|
|
Assignee | |
Comment 8•17 years ago
|
||
I'm sorry about that -- it was still green when I got pulled away by family issues.
You need to log in
before you can comment on or make changes to this bug.
Description
•