locale not exposed for document frame

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Scott Haeger, Assigned: Aaron Leventhal)

Tracking

(Blocks: 1 bug, {access})

Trunk
x86
Linux
access
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

11 years ago
The locale is not exposed for the document frame node.  Please note http://lxr.mozilla.org/seamonkey/source/accessible/src/atk/nsMaiInterfaceDocument.cpp#55
(Assignee)

Updated

11 years ago
Blocks: 368880
(Assignee)

Updated

11 years ago
Keywords: access
(Assignee)

Comment 1

11 years ago
Created attachment 265339 [details] [diff] [review]
Needs testing
(Assignee)

Comment 2

11 years ago
Created attachment 265589 [details] [diff] [review]
Works correctly if content-language is set properly.
(Assignee)

Updated

11 years ago
Attachment #265339 - Attachment is obsolete: true
(Assignee)

Comment 3

11 years ago
Comment on attachment 265589 [details] [diff] [review]
Works correctly if content-language is set properly.

Test on www.hallo.de and it reports "de".

On pages that don't set the content-language you'd have to assume it's the same locale as the system, I guess.
Attachment #265589 - Attachment description: For some reason I keep getting an empty string from |doc->GetHeaderData(nsAccessibilityAtoms::headerContentLanguage, locale);| → Works correctly if content-language is set properly.
Attachment #265589 - Flags: review?(surkov.alexander)
(Assignee)

Updated

11 years ago
Attachment #265589 - Attachment is obsolete: true
Attachment #265589 - Flags: review?(surkov.alexander)
(Assignee)

Comment 4

11 years ago
Created attachment 265609 [details] [diff] [review]
The best we can get -- many pages don't indicate what language they're in

1) Try on <body>
2) Try on <html>
3) Try content-language
4) If we don't know the language we'll return NULL
Attachment #265609 - Flags: review?(surkov.alexander)

Comment 5

11 years ago
Comment on attachment 265609 [details] [diff] [review]
The best we can get -- many pages don't indicate what language they're in


>+      if (!content ) {

nit: please remove space
Attachment #265609 - Flags: review?(surkov.alexander) → review+
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 6

11 years ago
Created attachment 265765 [details] [diff] [review]
bustage fix

aaronlev, this was checked in as a bustage fix. Can you please OK this?

Comment 7

11 years ago
Comment on attachment 265765 [details] [diff] [review]
bustage fix

Sorry, I missed this. Thank your for the fix.
Attachment #265765 - Flags: review+
(Assignee)

Comment 8

11 years ago
I'm sorry about that -- it was still green when I got pulled away by family issues.
You need to log in before you can comment on or make changes to this bug.