381184 - 76 validation markup errors in TB 1.5 release notes

Status: VERIFIED WORKSFORME

(www.mozilla.org :: General, defect)

Description

[Gérard Talbot]

In the same spirit of bug 151557, I believe the Thunderbird 1.5 release notes markup code should be upgraded so that it passes markup validation. Right now, that page has 76 validation markup errors.

http://validator.w3.org/check?uri=http://www.mozilla.com/en-US/thunderbird/releases/1.5.html

I wish this bug could be fixed at the same time of fixing bug 378513.
If I had editing/updating privileges access to mozilla.com, I would certainly be able to fix this bug.

Comment 1

[Samuel Sidler (old account; do not CC)]

Gérard, you should be able to create a patch for this, regardless of having mozilla.com access or not.

Comment 2

[Gérard Talbot]

Attachment: Suggested patch for this bug

In this patch is the whole webpage corrected, only with needed corrections to fix this bug.

- Missing closing </p> at lines 83 (col 80) and 136 (col 146)

- Missing " /" at lines 177 (col 71), line 182 (col 71), line 187 (col 71), line 191 (col 71), line 196 (col 71),

- Missing closing </p> at line 363 (col 68)

- Missing closing </p> at line 397 (col 40)

- Lines 427 and 429 were removed since there were 2 <ul id="nav">

- The 2 <script>s at lines 430 and 431 were improperly nested and need to be inserted into an <li> element.

Once the file (corrected webpage) has been loaded, it will be necessary to verify if the 2 scripts at lines 430 and 431 work as expected. As far as I can anticipate, I believe these 2 scripts should work like before. The only things which were modified is the proper nesting of <li> and the scripts and the only thing that should change is the validation markup errors.

Comment 3

[Reed Loden [:reed]]

(In reply to comment #2)
> Created an attachment (id=265972) [details]
> Suggested patch for this bug
> 
> In this patch is the whole webpage corrected, only with needed corrections to
> fix this bug.

This is not a patch, which makes it quite difficult to tell what your changes are. You can checkout the thunderbird releases directory by using this command:
svn co http://svn.mozilla.org/projects/mozilla.com/trunk/en-US/thunderbird/releases/

Once you have made your changes to the files you wish to touch, just use "svn diff > patchname.diff" to save your changes into a patch, which you can then attach to the bug.

Comment 4

[Gérard Talbot]

Hello Reed, thanks for your reply.
 
> This is not a patch, which makes it quite difficult to tell what your changes
> are. You can checkout the thunderbird releases directory by using this command:
> svn co
> http://svn.mozilla.org/projects/mozilla.com/trunk/en-US/thunderbird/releases/

I can view the PHP page 
http://svn.mozilla.org/projects/mozilla.com/trunk/en-US/thunderbird/releases/1.5.html
and even view the spots where the corrections would be needed but I have no CVS or privileges to use that "svn co" command. svn co command is unix or something and I don't know how to execute it.

> Once you have made your changes to the files you wish to touch, just use "svn
> diff > patchname.diff" to save your changes into a patch

Again, that svn diff > patchname.diff must be an unix command executable via CVS. I don't use CVS; never have.

Comment 5

[Gérard Talbot]

Attachment: Proposed patch on the php file

This proposed patch applies to the file
http://svn.mozilla.org/projects/mozilla.com/trunk/en-US/thunderbird/releases/1.5.html
Line numbers and column applies to that file.

- Missing closing </p> at lines 36 (col 80) and 83 (col 146)

- Missing " /" at lines 120 (col 71), line 124 (col 71), line 128 (col 71),
line 132 (col 71), line 136 (col 71),

- Missing closing </p> at line 291 (col 68)

- Missing closing </p> at line 325 (col 40)

- Lines 350 and 352 were removed since there were 2 <ul id="nav">

- The 2 <script>s at lines 353 and 354 were improperly nested and needed to be
inserted into an <li> element with its correspondent </li>.

Once applied, the file (corrected webpage) will need to be verified to see 
if the 2 scripts nested in a <li></li> work as expected.

Comment 6

[Gérard Talbot]

This has been fixed for an unknown amount of time. There are still 2 minor issues with the current webpage:

Line 96: <a href=" http://support.mozilla.com/en-US/kb/Other+Firefox+support">Other Firefox Support</a>
There is a leading blank space in the href attribute

Line 196:  <h3 id="download"><a name="download">Downloading Thunderbird 1.5</a></h3>
Duplication of download anchor

... but since the webpage passes validation, I'm resolving this bug as WORKSFORME.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

http://validator.w3.org/check?uri=http%3A%2F%2Fwww.mozilla.com%2Fen-US%2Fthunderbird%2Freleases%2F1.5.html&charset=(detect+automatically)&doctype=Inline&group=0

Verified