381477 - Bookmark toolbar context menu items are all disabled on first use (only with Ctrl-click)

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Cmd+N.
2. Ctrl+click an item on the bookmarks toolbar.

Result: "Get Info", etc. are disabled.  Only "New Bookmark..." and other "New" items are enabled.

Comment 1

[Joey Minta]

This works fine if you do right click (enable two-finger clicking), but fails if you do ctrl+click.  The difference is in the timing of toolbar.xml's mousedown and the onpopupshowing event for the popup.  For the two-finger clicking, the mousedown fires first (which means there's a selection, so the appropriate nodes are enabled).  For ctrl+click, onpopupshowing is fired first, so there's no selection, and the items are disabled.  This can be fixed by putting http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/placesOverlay.xul#103
into a timeout, but I'm wondering if this isn't a lower level event-bug for mac.

Comment 2

[Jesse Ruderman]

Colin, please see comment 1.

Comment 3

[Asaf Romano (gone)]

bug 368397 was supposed to fix this...

Comment 4

[Josh Aas]

I worked on this for a bit today, it is a cocoa widgets bug. I know what is going on, should have a patch soon. Basically we send a context menu event from menuForEvent: and then the mouse event, then another context menu event.

Comment 5

[Josh Aas]

The patch on bug 389542 fixes this, but I don't understand why yet. Still reading through it, just wanted to note that here.

Comment 6

[Steven Michaud [:smichaud] (Retired)]

Fixed by patch for bug 389542, which just landed on trunk.