381846 - Selecting a bookmark or new window from the dock menu does not bring application to the front

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Paul Borokhov (lensovet)]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: 

Selecting a bookmark from the dock menu does not bring Camino to the front, even though it really should.

Reproducible: Always

Comment 1

[Paul Borokhov (lensovet)]

Attachment: Simple way to make sure that Camino is active when a bookmark is opened

This doesn't apply to the "New window" menu item, however.

Comment 2

[Paul Borokhov (lensovet)]

Attachment: Revised version, also fixes the "New Window" menu item

This patch also fixes the "New Window" menu item. We might also want to check who the sender if first before doing the app activation.

Comment 3

[Chris Lawson (gone)]

Confirming per the status meeting.

Comment 4

[Paul Borokhov (lensovet)]

can the patch get a little love?

the only thing to think about here is whether there are any instances in which we would be opening pages or bookmarks and NOT want Camino to come to the front. Do such situations even exist?

Comment 5

[Chris Lawson (gone)]

Comment on attachment 265924 [details] [diff] [review]
Revised version, also fixes the "New Window" menu item

r=me on the code, but I haven't had a chance to test it yet. In regards to comment 4, I don't think we were able to come up with any situations where we wouldn't want to activate.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 265924 [details] [diff] [review]
Revised version, also fixes the "New Window" menu item

r=ardissone since it works as expected in my tests.

However, in the future please use cvs diff -u8N from either /mozilla/camino (preferred) or /mozilla when making diffs (patch had a little issue with the lack of context and lack of newline in this patch).

Comment 7

[Stuart Morgan]

Comment on attachment 265924 [details] [diff] [review]
Revised version, also fixes the "New Window" menu item

AppleScript will be able to interact with bookmarks in the near future (and in general I don't think we should fix a very specific problem at such a general location, since it invites regressions either now or later). Activating the app should be as specific to the Dock menu as possible.

Comment 9

[Chris Lawson (gone)]

Paul, hope you don't mind...I've got a patch that addresses Stuart's issue with this. I'll post it shortly.

Comment 10

[Chris Lawson (gone)]

Attachment: fix v1.1

Only applies to actions coming in via the Dock menu. Presumably this doesn't need another round of review and can go straight to sr.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 342179 [details] [diff] [review]
fix v1.1

r- since this causes us to fail to produce a browser window with a new profile, as discussed on irc.

Camino[48163]: *** -[MainController menu]: unrecognized selector sent to instance 0x942f50
Camino[48163]: Exception raised during posting of notification.  Ignored.  exception: '*** -[MainController menu]: unrecognized selector sent to instance 0x942f50'  invoked observer method: '*** -[MainController applicationDidFinishLaunching:]'  observer: 0x942f50  notification name: 'NSApplicationDidFinishLaunchingNotification'

Comment 12

[Chris Lawson (gone)]

Attachment: fix v1.11

Whoops. Make sure we have an id that's actually of the proper class before we go sending it |menu| messages it might not respond to.

Comment 13

[Stuart Morgan]

Comment on attachment 342184 [details] [diff] [review]
fix v1.11

sr=smorgan

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.

Comment 15

[Mehmet]

It works on latest nightly 2.0 M1.9 dated 25-Oct-2008. 

Thank you very much.