Closed Bug 381902 Opened 13 years ago Closed 12 years ago

Figure out the minimum set of makefiles needed for the build system

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Spun off from bug 380846.

XULRunner apps with a libxul-sdk that use the build system don't need to generate hundreds of makefiles just to run. Need to figure out the minimum set common to these apps.
Attached patch Patch (obsolete) — Splinter Review
This seems to be all that is necessary to get the build system going for XULRunner apps with a libxul-sdk.
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #266859 - Flags: review?(benjamin)
Comment on attachment 266859 [details] [diff] [review]
Patch

I think we should move all of the libxul makefiles out of allmakefiles.sh into toolkit/toolkit-makefiles.sh and source that conditionally.
Attachment #266859 - Flags: review?(benjamin) → review-
Attached patch Patch, v2Splinter Review
Ok, this patch conditionally includes toolkit-makefiles.sh when we're not using a libxul-sdk.
Attachment #266859 - Attachment is obsolete: true
Attachment #277328 - Flags: review?(ted.mielczarek)
Attachment #277328 - Flags: review?(ted.mielczarek) → review?(benjamin)
Attachment #277328 - Flags: review?(benjamin)
Attachment #277328 - Flags: review+
Attachment #277328 - Flags: approval1.9+
Since somebody removed gfx/src/mac from the tree. It is best to removed it from the toolkit makefiles.
(In reply to comment #4)

Filed bug 394464.

This is FIXED.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
This broke depend builds for once cycle because you didn't update client.mk (it "works" the second time because client.mk ignores the file because it thinks you didn't check it out yet).
(In reply to comment #6)

Oops, filed bug 395059 for that.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.