Closed
Bug 395059
Opened 17 years ago
Closed 16 years ago
Update client.mk to reflect changes from bug 381902
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(2 files, 1 obsolete file)
1.24 KB,
patch
|
benjamin
:
review+
benjamin
:
approval1.9+
|
Details | Diff | Splinter Review |
976 bytes,
patch
|
benjamin
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
Update client.mk to reflect changes from bug 381902. Need to put the new makefiles in the CONFIG_STATUS_DEPS variable.
Comment 1•17 years ago
|
||
At the same time, the old mailnews and themes makefiles files can go away from http://mxr.mozilla.org/mozilla/source/client.mk#1020
Assignee | ||
Comment 2•17 years ago
|
||
This should do it. I pulled out tabs too.
Comment 3•17 years ago
|
||
I don't understand why the makefiles.sh need to be in config_status_deps, but confvars.sh does need to be there.
Assignee | ||
Comment 4•17 years ago
|
||
Comment on attachment 280263 [details] [diff] [review] Patch Hmm... yeah. I was just adding the makefiles to keep the old behavior, but you're right that it doesn't make a whole lot of sense. I'll fix this patch in a bit.
Attachment #280263 -
Attachment is obsolete: true
Attachment #280263 -
Flags: review?(benjamin)
Comment 5•17 years ago
|
||
well, if it is not there, is configure still re-run to create the needed Makefiles when we add new ones to a makefiles.sh?
Comment 6•17 years ago
|
||
No, and it shouldn't be necessary as make-makefiles will take care of it.
Assignee | ||
Comment 7•17 years ago
|
||
No longer depend on makefiles, take confvars.sh into account.
Attachment #281108 -
Flags: review?(benjamin)
Updated•17 years ago
|
Attachment #281108 -
Flags: review?(benjamin)
Attachment #281108 -
Flags: review+
Attachment #281108 -
Flags: approval1.9+
Assignee | ||
Comment 8•17 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 9•16 years ago
|
||
Comment on attachment 281108 [details] [diff] [review] Patch >+ $(wildcard $(addsuffix confvars.sh,$(wildcard */))) \ Should this not be: $(wildcard $(addsuffix confvars.sh,$(wildcard $(TOPSRCDIR)/*/))) \ See bug 388547 comment 49.
Assignee | ||
Comment 10•16 years ago
|
||
Yeah, probably.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 11•16 years ago
|
||
Attachment #296839 -
Flags: review?(benjamin)
Updated•16 years ago
|
Attachment #296839 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 12•16 years ago
|
||
Comment on attachment 296839 [details] [diff] [review] Use TOPSRCDIR braindead simple change to get make to find the correct directory for dependencies.
Attachment #296839 -
Flags: approval1.9?
Updated•16 years ago
|
Attachment #296839 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 13•16 years ago
|
||
Fixed again, that's jwatt.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 16 years ago
Resolution: --- → FIXED
Comment 14•16 years ago
|
||
(In reply to comment #9) >(From update of attachment 281108 [details] [diff] [review]) >>+ $(wildcard $(addsuffix confvars.sh,$(wildcard */))) \ >Should this not be: > $(wildcard $(addsuffix confvars.sh,$(wildcard $(TOPSRCDIR)/*/))) \ $(wildcard $(addsuffix confvars.sh,$(wildcard $(TOPSRCDIR)/*/))) \ :-P
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•