382092 - Simple canvas cleanups

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Eli Friedman]

Attachment: Patch

Some easy cleanups; the only non-trivial change is switching to using the newly fixed RenderDocument for doing drawWindow calls.  Should make things easier to understand when you switch it to Thebes.

This does get rid of the branch compatibility of this file, but I don't think we care because our next release will be off 1.9 anyway.

Comment 1

[Eli Friedman]

Should I ask someone else for review?

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 266174 [details] [diff] [review]
Patch

Sorry, I missed the review request.. I guess this is ok -- for a while there I was thinking to keep the MOZILLA_1_8 stuff around to keep this file in sync with the 1.8 branch version, in case I needed to fix anything on both.  But that was a long time ago, so r+ :)

Comment 3

[Eli Friedman]

Comment on attachment 266174 [details] [diff] [review]
Patch

Could you make that an r+sr? (It doesn't seem worth bothering someone else for an sr for a patch like this.)

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 266174 [details] [diff] [review]
Patch

whoops, yep, sorry

Comment 5

[Eli Friedman]

Checked in.  This caused some unexpected passes on mac by fixing some rounding errors; my best guess is that it is due to using gfxASurface::CONTENT_COLOR as a parameter for aThebesContext->PushGroup instead of gfxASurface::CONTENT_COLOR_ALPHA. (Bugs affected: bug 382039, bug 382399, bug 382040, bug 381831, bug 381834, bug 383386.)