382105 - Double click selection extends beyond punctuation with new textframe

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

On builds with the new textframe enabled, double clicking text (say the "mozilla" in mozilla.org in the location bar) results in "mozilla." being selected instead of "mozilla".

Comment 1

[Ryan VanderMeulen [:RyanVM]]

This WFM now.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Filed bug 383542 for other text selection weirdness with the new textframe.

Comment 3

[philippe (part-time)]

I'll reopen this, I still can see those issues on OS X.

example: in comment 0, selecting by double-click the last instance of "mozilla" selects the word, the closing " and the period.

2007060704 build with new textframe.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I checked in a fix for this.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Still seeing this with a win32 trunk build with the new textframe enabled today.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

What are the settings of your layout.word_select.* prefs?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

layout.word_select.eat_space_to_next_word = true
layout.word_select.stop_at_punctuation = true

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

OK, I checked in ANOTHER fix. Should really be fixed this time :-)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Attachment: Screenshot of new behavior

Or not, I'm afraid. Attached is a screenshot of what I'm seeing now if I double click the word mozilla in the location.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Also, on Linux, double-clicking mozilla leads to the period on both sides to be selected (".mozilla.").

Comment 11

[Jesse Ruderman]

Even more strange: if I double-click past the end of the URL, everything *but* the last section becomes selected.  This used to be a convenient way to copy a bug number ;)

This also happens with a simple testcase:
data:text/html,<input value="a b c">

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

1) simplify the code a bit more
2) don't check *aSawBeforeType when we're looking for punctuation
3) exit early without changing *aOffset when there's no clusters in the direction we're looking

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Nice :)