382404 - Clean up save search UI

Status: NEW

(Thunderbird :: Search, defect)

Description

[Phil Ringnalda (:philor)]

<mscott>: and noticed lots of little UI issues in the saved search dialog
<mscott>: here are a couple: for local folders, we disable the search online checkbox, I think we should just hide it altogether...I'm also wondering if we can drop the imap/news reference from the text in that checkbox
<mscott>: in the actual search criteria
<mscott>: if you click customize to add a custom header, the drop down doesn't interact correctly with the custom header you (may) add in the custom header dialog. We should select that header when the custom hdr dialog returns
<mscott>: currently it stays at "Customize" which isn't helpful
<mscott>: I think the advanced search dialog does a little better than the saved search dialog in this regard
<philor>: ick, trunk Mac, it's not customize, it's "Customi..."

At which point I wandered off into widget things, and stale build things. Looks to me like the advanced search dialog adds your new custom header to the list, but retains your previous selection, while the save search dialog doesn't add your header and shows Customize.

Comment 1

[Wayne Mery (:wsmwk)]

comment 0 mentions several items, but the "online" item jumps out at me. methinks this is either a duplicate of a newer bug filed post 3.0, or no longer relevant given the changes made in v3.anything  

perhaps one of you remembers which bug that might be?

Comment 2

[:aceman]

The disabled "online" checkbox is still there. I can hide it.

The customize menuitem is quite problematic and I suggest it gets fixed in bug 524662.

Comment 3

[:aceman]

But there is an error after Customize is used in the Saved Search dialog:
Error: ReferenceError: UpdateAfterCustomHeaderChange is not defined
Source File: chrome://messenger/content/mailWidgets.xml
Line: 1710

This one does not happen if Customize is used from the Filter editor.