Closed Bug 382495 Opened 15 years ago Closed 14 years ago

More missing preferences

Categories

(SeaMonkey :: Startup & Profiles, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(4 files, 1 obsolete file)

Some more missing prefs and some incorrect pref migrations picked up off the news group.
Attachment #266656 - Flags: review?(neil)
Attachment #266656 - Flags: review?(neil) → review+
Patch checked in -> fixed.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
More prefs to add coming up later.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Fix part 2 (obsolete) — Splinter Review
These are some more missing ones off the newsgroup and I've also added in some after having gone through all the "prefstring"s in the suite/common/pref files. I'll try and remember to check the mailnews ones sometime.
Attachment #266942 - Flags: review?(neil)
Additional change to get the browser.windows.loadOnNewWindow pref migrated correctly.
Attachment #266942 - Attachment is obsolete: true
Attachment #266994 - Flags: review?(neil)
Attachment #266942 - Flags: review?(neil)
Comment on attachment 266994 [details] [diff] [review]
Fix part 2 v2 (checked in)

>+  // XXX Translate to new profile folder if in old profile folder?
>+  MAKESAMETYPEPREFTRANSFORM("browser.cache.disk.parent_directory",     String),
I don't think we should migrate this pref.

>   // XXX Bug 381159 When suite uses Toolkit's DM backend, we need to
>   // activate this code.
> #ifdef SUITE_USING_TOOLKIT_DM
>   MAKESAMETYPEPREFTRANSFORM("browser.download.autoDownload",           Bool),
>   MAKESAMETYPEPREFTRANSFORM("browser.download.lastLocation",           Bool),
>-
>   MAKEPREFTRANSFORM("browser.downloadmanager.behavior", 0, Int,
>                     DownloadManager),
>+#else
>+  MAKESAMETYPEPREFTRANSFORM("browser.downloadmanager.behavior",        Int),
> #endif
Suite supports autoDownload and lastLocation so they should be outside the #ifdef
Attachment #266994 - Flags: review?(neil) → review+
(In reply to comment #5)
> (From update of attachment 266994 [details] [diff] [review])
> >+  // XXX Translate to new profile folder if in old profile folder?
> >+  MAKESAMETYPEPREFTRANSFORM("browser.cache.disk.parent_directory",     String),
> I don't think we should migrate this pref.

I'll remove it before checkin.

> 
> >   // XXX Bug 381159 When suite uses Toolkit's DM backend, we need to
> >   // activate this code.
> > #ifdef SUITE_USING_TOOLKIT_DM
> >   MAKESAMETYPEPREFTRANSFORM("browser.download.autoDownload",           Bool),
> >   MAKESAMETYPEPREFTRANSFORM("browser.download.lastLocation",           Bool),
> >-
> >   MAKEPREFTRANSFORM("browser.downloadmanager.behavior", 0, Int,
> >                     DownloadManager),
> >+#else
> >+  MAKESAMETYPEPREFTRANSFORM("browser.downloadmanager.behavior",        Int),
> > #endif
> Suite supports autoDownload and lastLocation so they should be outside the
> #ifdef

Actually we already do them under "browser.download." in the list of pref branches that we migrate. So I could just remove them from this ifdef as well.
(In reply to comment #6)
> Actually we already do them under "browser.download." in the list of pref
> branches that we migrate. So I could just remove them from this ifdef as well.

Actually I won't, the browser.downloads is ifndef SUITE_USING_TOOLKIT_DM so we'll still need them there (at least as a reminder). I've added in a comment anyway.
Attachment #266656 - Attachment description: The fix → The fix (checked in)
Comment on attachment 266994 [details] [diff] [review]
Fix part 2 v2 (checked in)

Both the patches are checked in (the first was checked in a while ago). I'm leaving this open till I've double checked the mailnews pref migrations.
Attachment #266994 - Attachment description: Fix part 2 v2 → Fix part 2 v2 (checked in)
I tried  profile migration with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a6pre) Gecko/2007060302 SeaMonkey/2.0a1pre and migrated an older seamonkey profile. Following prefs arn't migrated (with my values):

user_pref("browser.search.mode", 1);
user_pref("browser.search.opensidebarsearchpanel", false);
user_pref("image.animation_mode", "none"); 
user_pref("network.cookie.lifetimePolicy", 2);
user_pref("plugin.expose_full_path", true);
(In reply to comment #9)
> I tried  profile migration with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
> rv:1.9a6pre) Gecko/2007060302 SeaMonkey/2.0a1pre and migrated an older
> seamonkey profile. Following prefs arn't migrated (with my values):
> user_pref("browser.search.mode", 1);
> user_pref("browser.search.opensidebarsearchpanel", false);
> user_pref("image.animation_mode", "none"); 
> user_pref("network.cookie.lifetimePolicy", 2);

My "Fix Part 2 v2" patch was checked in after the build you used was generated. Please check todays build.

> user_pref("plugin.expose_full_path", true);

Opps, looks like I added this one to the Thunderbird migrator but not the SeaMonkey migrator :-(
(In reply to comment #10)

> > user_pref("browser.search.mode", 1);
> > user_pref("browser.search.opensidebarsearchpanel", false);
> > user_pref("image.animation_mode", "none"); 
> > user_pref("network.cookie.lifetimePolicy", 2);
> 
> My "Fix Part 2 v2" patch was checked in after the build you used was generated.
> Please check todays build.

checked with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a6pre) Gecko/2007060401 SeaMonkey/2.0a1pre and the prefs are migrated 
browser.link.open_newwindow.restriction is not migrated with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/2007060714 SeaMonkey/2.0a1pre, although browser.link.open_newwindow is migrated properly.
Depends on: 384114
This fixes bug 384114 (ui.allow_platform_file_picker) and also some mailnews prefs - I got round to doing the pass through the mailnews pref panes that I said I'd do, and found a couple of mistakes and a couple of missing prefs.
Attachment #268113 - Flags: review?(neil)
Comment on attachment 268113 [details] [diff] [review]
Fix part 3 (checked in)

>+#ifdef XP_UNIX
>+  MAKESAMETYPEPREFTRANSFORM("ui.allow_platform_file_picker",           Bool),
>+#endif
You also need #ifndef XP_MACOSX (or you could just copy ui.*)
Attachment #268113 - Flags: review?(neil) → review+
Attachment #268113 - Attachment description: Fix part 3 → Fix part 3 (checked in)
Depends on: 385685
I've not heard or found any others yet (that aren't covered by other bugs), so I'm marking this as fixed. We should raise any others in different bugs.
Status: REOPENED → RESOLVED
Closed: 15 years ago14 years ago
Resolution: --- → FIXED
Depends on: 396033
Somehow these made it into the Thunderbird migrator but not the SeaMonkey one :-/
Attachment #280781 - Flags: review?(neil)
Attachment #280781 - Flags: review?(neil) → review+
Attachment #280781 - Attachment description: Missing plugin pref migration → Missing plugin pref migration (checked in)
Target Milestone: --- → seamonkey2.0alpha
Depends on: 461912
You need to log in before you can comment on or make changes to this bug.