382566 - Clean up SeaMonkey packages file

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Frank Wein [:mcsmurf]]

The SeaMonkey packages file still includes references to some files which are no longer built (see Windows SeaMonkey tinderbox log), this should be changed. I'll add further comments and Bug #s to the bug here as time moves on.
Current changes to suite/installer/windows/packages:
Remove extensions\[e-mail]\components\inspector.dll and extensions\[e-mail]\components\inspector.xpt (Bug 338746)
Remove gkgfxwin.dll: this was for the old GFX toolkit
Remove nsprefm.dll: this file was built by profile/pref-migrator/src/Makefile.in, which is only in the build process if MOZ_SINGLE_PROFILE is not set. MOZ_SINGLE_PROFILE is set to 1 when MOZ_XUL_APP is set.

Comment 1

[Frank Wein [:mcsmurf]]

Remove editor.dll: editor was moved to gklayout as part of Bug 347664
Remove intlcmpt.dll/intlcmpt.xpt: intlcmpt was removed from the build as part of Bug 352180

Comment 2

[Frank Wein [:mcsmurf]]

Remove mozucth.dll/mozucth.xpt: mozucth was already removed from the build in 2002(!), checkin comment in CVS "bug 156723 - remove xfer and ucth from the build - no longer used r=law, sr=blake, a=asa" that bug does not contain anything about ucth itself though

Comment 3

[Frank Wein [:mcsmurf]]

Attachment: Clean-up, part 1

This patch here should also fix Bug 382571.

Comment 4

[Mark Banner (:standard8)]

The palm sync code has also moved (at the switch over, its now an extension), so at some stage we also need to do the following:

Remove:

;these Palm Sync files are conditionally built so would not exist unless built
bin\mozABConduit.dll
bin\PalmSyncProxy.dll
bin\PalmSyncInstall.exe
bin\components\palmsync.dll
bin\components\palmsync.xpt
bin\palm.html

Add:

bin\extensions\p@m\install.rdf
bin\extensions\p@m\mozABConduit.dll
bin\extensions\p@m\PalmSyncInstall.exe
bin\extensions\p@m\PalmSyncProxy.dll
bin\extensions\p@m\palmsync.dll
bin\extensions\p@m\palmsync.xpt
bin\extensions\p@m\defaults\preferences\palmsync.js

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 266764 [details] [diff] [review]
Clean-up, part 1

r=me, (I'm happy for this to be checked in) but please investigate whether or not we need to make the following changes as well - I don't know if they do, I just picked up they were in the res directory or packages file and not in the res directory:

remove bin\res\rdf\{...}
add bin\res\cmessage.txt
add bin\res\bloatcycle.html
add bin\res\html\*


Is this likely to fix bug 382570 as well? If so please add dep.

Comment 6

[Tobias Fischer]

(In reply to comment #5)
> (From update of attachment 266764 [details] [diff] [review])
[...]
> Is this likely to fix bug 382570 as well? If so please add dep.
> 
No, the first Patch will not fix Bug 382570 as well. I have just tried and copied the files:

bin\res\langGroups.properties
bin\res\language.properties

from an older tpol-Build into the ..\res Directory from Build 2007060102, and this have fixed Bug 382571 for me, but Bug 382570 was still alive. 

Also I am a little bit confused, why in tpol-Suiterunner-Builds (2007052023) there are 243 Objects in the ..\components directory, and in new Suiterunner-Trunk-Builds from sea-win32-tbox Clbr VM-release-Box only 95 Objects?

Comment 7

[Frank Wein [:mcsmurf]]

Attachment: Clean-up, part 1 (as checked in)

Includes the changes from the review comment. bloatcycle.html is for tinderbox tests only. cmessage.txt seems to be used, Thunderbird does not package it though (dunno for what reason, FF does).

Comment 8

[Frank Wein [:mcsmurf]]

Remove AcctIdl.dll/AcctIdl.xpt: Was already removed from the source tree 2001, see Bug 103054
Remove nativapp.dll: Removed as part of Bug 96524
Fix typo imcicon.xpt<->imgicon.xpt

Comment 9

[Frank Wein [:mcsmurf]]

Remove pipnss.jar: Only exists when building a non-MOZ_XUL_APP application, see http://lxr.mozilla.org/mozilla/source/security/manager/ssl/resources/jar.mn
Remove imgxbm.dll: Merged to imglib2.dll as part of Bug 168048
Remove imgbmp.dll: Merged to imglib2.dll as part of Bug 168048

Comment 10

[Frank Wein [:mcsmurf]]

Attachment: Clean-up, part 2

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 267418 [details] [diff] [review]
Clean-up, part 2

This looks ok, r=me. Don't forget bug 382438 as well (fastfind.xpt), but we can do that in another patch.

Comment 12

[Frank Wein [:mcsmurf]]

Comment on attachment 267418 [details] [diff] [review]
Clean-up, part 2

Checked in (with the fastfind.xpt change).

Comment 13

[Mark Banner (:standard8)]

Attachment: More clean up (checked in)

Rather than create a new bug, I'll just hi-jack this one. Here's some more changes I found, mostly removals.

I'm not quite sure why Frank added bin\components\bayesflt.dll - its a dll for non-static mailnews, and as we're building static, we don't need it.

Comment 14

[Frank Wein [:mcsmurf]]

Comment on attachment 280196 [details] [diff] [review]
More clean up (checked in)

Looks ok. Resolve the bug as FIXED when the patch is checked in?

Comment 15

[Frank Wein [:mcsmurf]]

All fixed now.