Closed
Bug 382760
Opened 18 years ago
Closed 17 years ago
MozillaBuild draws text with vertical lines next to every character typed
Categories
(Firefox Build System :: MozillaBuild, task, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bent.mozilla, Assigned: bhearsum)
References
Details
Attachments
(3 files)
6.58 KB,
image/jpeg
|
Details | |
3.68 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
3.67 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
This is a really really weird problem, but the MozillaBuild 1.1 version of MSYS (rxvt?) has some problems rendering text. I'll attach a screenshot to explain it.
I searched around for hours trying to figure out what was going on to no avail. Finally I realized it happens because I like the ClearType font smoothing on WindowsXP and have that enabled on all my machines. Flipping the font smoothing to Standard fixed my problem (but makes everything else look bad...).
Anyway, for anyone who is having this trouble you can find the font smoothing setting in the Display control panel, under the Appearance tab, by clicking on the Effects button.
Comment 1•17 years ago
|
||
For the record, this affects Vista as well (where ClearType is on by default)
Comment 2•17 years ago
|
||
I can confirm this. We're seeing this in one of our labs, but not all. I'll try to figure out if anything else is different aside from the smoothing you describe.
Comment 3•17 years ago
|
||
The lab that is exhibiting this symptom has new LCD widescreens -- this problem appeared only when the monitors were switched (from standard-aspect screens).
Assignee | ||
Updated•17 years ago
|
Blocks: 406085
Component: Build Config → MozillaBuild
Product: Core → mozilla.org
QA Contact: build-config → mozillabuild
Version: Trunk → other
Assignee | ||
Comment 4•17 years ago
|
||
AFAIK the fix for this is changing the font. We should be able to get this into 1.2. What do you think, Ted?
Assignee: nobody → bhearsum
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Comment 5•17 years ago
|
||
I think we're going to respin to pick up bug 409114 anyway, so that's ok.
Assignee | ||
Comment 6•17 years ago
|
||
Mass re-assign of MozillaBuild bugs into mozilla.org:MozillaBuild
Updated•17 years ago
|
Priority: -- → P2
Assignee | ||
Comment 7•17 years ago
|
||
I haven't been able to re-produce this in my VM, but this is the fix that I've seen everyone use. It makes the msys window slightly less nice, but still fine (imho). If anyone is that annoyed by it I'm sure they can change it locally :).
Attachment #294212 -
Flags: review?(ted.mielczarek)
Comment 8•17 years ago
|
||
Comment on attachment 294212 [details] [diff] [review]
[checked in] remove font specification when starting msys shell
This fixes it for me on Vista.
Attachment #294212 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 9•17 years ago
|
||
Checking in start-l10n.bat;
/cvsroot/mozilla/tools/build-environment/win32/start-l10n.bat,v <-- start-l10n.bat
new revision: 1.2; previous revision: 1.1
done
Checking in start-msvc6.bat;
/cvsroot/mozilla/tools/build-environment/win32/start-msvc6.bat,v <-- start-msvc6.bat
new revision: 1.7; previous revision: 1.6
done
Checking in start-msvc71.bat;
/cvsroot/mozilla/tools/build-environment/win32/start-msvc71.bat,v <-- start-msvc71.bat
new revision: 1.8; previous revision: 1.7
done
Checking in start-msvc8.bat;
/cvsroot/mozilla/tools/build-environment/win32/start-msvc8.bat,v <-- start-msvc8.bat
new revision: 1.10; previous revision: 1.9
done
Checking in start-msvc9.bat;
/cvsroot/mozilla/tools/build-environment/win32/start-msvc9.bat,v <-- start-msvc9.bat
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Priority: P2 → P3
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Attachment #294212 -
Attachment description: remove font specification when starting msys shell → [checked in] remove font specification when starting msys shell
Reporter | ||
Comment 10•17 years ago
|
||
This is still happening for me on XP with MB1.2... Lame!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 11•17 years ago
|
||
Oh, wow... switching to Courier New from Lucida Console works on XP with ClearType...
Maybe the default terminal font on XP is just different from Vista.
Comment 12•17 years ago
|
||
We can relnote it...not that we really have a place for release notes.
Assignee | ||
Updated•17 years ago
|
Priority: P3 → P2
Assignee | ||
Comment 13•17 years ago
|
||
I've been able to confirm that Courier New works fine with ClearType on XP and Vista. Is there anyone else still having this problem that can test this? Just s/Lucida Console/Courier New/ in your start-msvc batch file and see if it fixes the issue.
Assignee | ||
Comment 14•17 years ago
|
||
Reporter | ||
Comment 15•17 years ago
|
||
Sad... Lucida is so much prettier.
Assignee | ||
Updated•17 years ago
|
Attachment #294977 -
Flags: review?(ted.mielczarek)
Comment 16•17 years ago
|
||
Comment on attachment 294977 [details] [diff] [review]
[checked in] use courier new as the default font
Wish there was a better way than inflicting courier new on everyone. If we don't specify a font, does it use a system font or something? Could we instead just tell people that if they see this problem, change that font? Or do they have to edit the batch files anyway?
Attachment #294977 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 17•17 years ago
|
||
The only way to change the font here (that I know of) is editing the batch file(s).
Without specifying a font, it defaults to a working font on Vista (though, I'm not sure which font it is).
Without specifying a font on XP, it defaults to another font I can't identify, but has the vertical line problem.
Seeing as the default font works on Vista, we could special case XP to use Courier and not have everyone suffer ;-).
Personally, Courier doesn't bother me, but it sounds like I'm in the minority.
Comment 18•17 years ago
|
||
FWIW, I'm ok with checking this in, it's not a really big deal, it'd just be nice if we could find a better solution.
Assignee | ||
Updated•17 years ago
|
Summary: MozillaBuild 1.1 draws text with vertical lines next to every character typed → MozillaBuild draws text with vertical lines next to every character typed
Assignee | ||
Comment 19•17 years ago
|
||
Comment on attachment 294977 [details] [diff] [review]
[checked in] use courier new as the default font
Checking in start-l10n.bat;
/cvsroot/mozilla/tools/build-environment/win32/start-l10n.bat,v <-- start-l10n.bat
new revision: 1.3; previous revision: 1.2
done
Checking in start-msvc6.bat;
/cvsroot/mozilla/tools/build-environment/win32/start-msvc6.bat,v <-- start-msvc6.bat
new revision: 1.8; previous revision: 1.7
done
Checking in start-msvc71.bat;
/cvsroot/mozilla/tools/build-environment/win32/start-msvc71.bat,v <-- start-msvc71.bat
new revision: 1.9; previous revision: 1.8
done
Checking in start-msvc8.bat;
/cvsroot/mozilla/tools/build-environment/win32/start-msvc8.bat,v <-- start-msvc8.bat
new revision: 1.11; previous revision: 1.10
done
Checking in start-msvc9.bat;
/cvsroot/mozilla/tools/build-environment/win32/start-msvc9.bat,v <-- start-msvc9.bat
new revision: 1.3; previous revision: 1.2
done
Attachment #294977 -
Attachment description: use courier new as the default font → [checked in] use courier new as the default font
Assignee | ||
Updated•17 years ago
|
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: mozilla.org → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•