382963 - Modern Theme unavailable with current nightly (View->Apply Theme doesn't work)

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Johannes Walther]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1

After todays update of Seamonkey to current nightly (20070602) it started up with the classic look. It even lacks the entry Preferences/Appearance/Themes and no themes are available in View/Apply Theme, so I can't switch to the nice modern theme.
I now switched back to a good build. Please make modern theme available again.

Reproducible: Always

Comment 1

[Frank Wein [:mcsmurf]]

As a workaround you could try going to Tools->Add-Ons Manager, there click on themes and click on "Use theme" with Modern Theme being selected. But yeah, the Theme list under View->Apply Theme being empty looks like a bug.

Comment 2

[Johannes Walther]

Ah that works, thanks. I wasn't aware of this new way things are now.
But yes, getting it work the old, apparent way would be great.

Comment 3

[[e-mail]]

Attachment: Proposed patch

Note: depends on bug 383116 which I only just checked in.

Comment 4

[Mark Banner (:standard8)]

I've just applied this (and picked up bug 383116), on start up I'm getting:

WARNING: Creation of "{69bb8313-2d4f-45ec-97e0-d39da58ecce9}" in progress (Reentrant GS - see bug 194568): file /mozilla/master/mozilla/xpcom/components/nsComponentManager.cpp, line 1644
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIRDFService.GetDataSource]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: file:///mozilla/master/mozilla/sm/dist/bin/components/nsExtensionManager.js :: anonymous :: line 5660"  data: no]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIRDFService.GetDataSource]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: file:///mozilla/master/mozilla/sm/dist/bin/components/nsExtensionManager.js :: anonymous :: line 5660"  data: no]
************************************************************
WARNING: unable to load datasource 'rdf:extensions': file /mozilla/master/mozilla/content/xul/templates/src/nsXULTemplateBuilder.cpp, line 1338

When I try to display the menu I get:

JavaScript error: chrome://navigator/content/navigator.js, line 2431: pref.getBoolValue is not a function

Have I missed something?

Comment 5

[Robert Kaiser]

I get the same as in comment #4 on the first opened browser window, but the menu works fine in the second and any following browser windows I open.

Comment 6

[Robert Kaiser]

The change mentioned in bug 384693 comment #3 fixes the issue I described in comment #5 and makes this patch work on all browser windows.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
> rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1

This bug is Trunk only, not 1.8.1 branch, isn't it ?

Comment 8

[[e-mail]]

(In reply to comment #7)
>(In reply to comment #0)
>>Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
>>rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1
>This bug is Trunk only, not 1.8.1 branch, isn't it ?
Comment #2 should have made that clear ;-)

Comment 9

[Mark Banner (:standard8)]

With this patch and the one on bug 383116 applied I get this error on startup:

###!!! ASSERTION: null ptr: 'aContainer != nsnull', file /mozilla/master/mozilla/rdf/base/src/nsRDFContainer.cpp, line 160
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFContainer.Init]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: file:///mozilla/master/mozilla/sm/dist/bin/components/nsExtensionManager.js :: getContainer :: line 359"  data: no]
************************************************************

Otherwise it seems to work fine.

Could you also do a patch for getting "Get New Themes" working? - or file a follow up bug.

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 271417 [details] [diff] [review]
Proposed patch

r=me if you s/etBoolValue/etBoolPref/ before checkin.

Also please file follow up patch/bug for the GetNewThemes option.

Comment 11

[[e-mail]]

Fix checked in.

To clarify, note that this fix does not work using debug builds for the first browser window unless you have previously opened the extension manager.

Comment 12

[Mark Banner (:standard8)]

(In reply to comment #9)
> With this patch and the one on bug 383116 applied I get this error on startup:
> 
> ###!!! ASSERTION: null ptr: 'aContainer != nsnull', file
> /mozilla/master/mozilla/rdf/base/src/nsRDFContainer.cpp, line 160
> ************************************************************
> * Call to xpconnect wrapped JSObject produced this error:  *
> [Exception... "Component returned failure code: 0x80004003
> (NS_ERROR_INVALID_POINTER) [nsIRDFContainer.Init]"  nsresult: "0x80004003
> (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
> file:///mozilla/master/mozilla/sm/dist/bin/components/nsExtensionManager.js ::
> getContainer :: line 359"  data: no]
> ************************************************************

FWIW this went away when I applied the patch on bug 383116 rather than my own
hand-altered version, so I guess I messed it up originally.

Comment 13

[[e-mail]]

Filed bug 391130 on the Get New Themes menuitem.

Comment 14

[Andrew Schultz]

with this landed, during startup I get the exceptions in comment 4 and I also see 5616 bytes leaked on bloatcycle.html.  nye also sees the exceptions and 5640 bytes leaked.

As a bonus, my view->apply themes menu only has "Get New Themes" and a separator.

Comment 15

[Andrew Schultz]

ugh, I only see problems with a debug build (non-debug build has classic & modern in view->apply themes)

Comment 16

[[e-mail]]

(In reply to comment #14)
>with this landed, during startup I get the exceptions in comment 4 and I also
>see 5616 bytes leaked on bloatcycle.html.  nye also sees the exceptions and
>5640 bytes leaked.
We now load EM on startup, so if it leaks, then so do we. File a bug on EM?

>As a bonus, my view->apply themes menu only has "Get New Themes" and a
>separator.
(In reply to comment #15)
>ugh, I only see problems with a debug build (non-debug build has classic &
>modern in view->apply themes)
We know about that. See the references to bug 383116.

Comment 17

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/200708070303 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

V.Fixed:
I'm not getting bug 384693 comment 4 exception anymore, and the 2 themes are there.