Closed
Bug 382963
Opened 17 years ago
Closed 17 years ago
Modern Theme unavailable with current nightly (View->Apply Theme doesn't work)
Categories
(SeaMonkey :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: joh_walt, Assigned: neil)
References
Details
Attachments
(1 file)
7.77 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 After todays update of Seamonkey to current nightly (20070602) it started up with the classic look. It even lacks the entry Preferences/Appearance/Themes and no themes are available in View/Apply Theme, so I can't switch to the nice modern theme. I now switched back to a good build. Please make modern theme available again. Reproducible: Always
Comment 1•17 years ago
|
||
As a workaround you could try going to Tools->Add-Ons Manager, there click on themes and click on "Use theme" with Modern Theme being selected. But yeah, the Theme list under View->Apply Theme being empty looks like a bug.
Updated•17 years ago
|
Summary: Modern Theme unavailable with current nightly → Modern Theme unavailable with current nightly (View->Apply Theme doesn't work)
Reporter | ||
Comment 2•17 years ago
|
||
Ah that works, thanks. I wasn't aware of this new way things are now. But yes, getting it work the old, apparent way would be great.
Assignee | ||
Comment 3•17 years ago
|
||
Note: depends on bug 383116 which I only just checked in.
Assignee: general → neil
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #271417 -
Flags: review?(bugzilla)
Comment 4•17 years ago
|
||
I've just applied this (and picked up bug 383116), on start up I'm getting: WARNING: Creation of "{69bb8313-2d4f-45ec-97e0-d39da58ecce9}" in progress (Reentrant GS - see bug 194568): file /mozilla/master/mozilla/xpcom/components/nsComponentManager.cpp, line 1644 ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIRDFService.GetDataSource]" nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)" location: "JS frame :: file:///mozilla/master/mozilla/sm/dist/bin/components/nsExtensionManager.js :: anonymous :: line 5660" data: no] ************************************************************ ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIRDFService.GetDataSource]" nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)" location: "JS frame :: file:///mozilla/master/mozilla/sm/dist/bin/components/nsExtensionManager.js :: anonymous :: line 5660" data: no] ************************************************************ WARNING: unable to load datasource 'rdf:extensions': file /mozilla/master/mozilla/content/xul/templates/src/nsXULTemplateBuilder.cpp, line 1338 When I try to display the menu I get: JavaScript error: chrome://navigator/content/navigator.js, line 2431: pref.getBoolValue is not a function Have I missed something?
Comment 5•17 years ago
|
||
I get the same as in comment #4 on the first opened browser window, but the menu works fine in the second and any following browser windows I open.
Comment 6•17 years ago
|
||
The change mentioned in bug 384693 comment #3 fixes the issue I described in comment #5 and makes this patch work on all browser windows.
Comment 7•17 years ago
|
||
(In reply to comment #0) > Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; > rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 This bug is Trunk only, not 1.8.1 branch, isn't it ?
Assignee | ||
Comment 8•17 years ago
|
||
(In reply to comment #7) >(In reply to comment #0) >>Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; >>rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 >This bug is Trunk only, not 1.8.1 branch, isn't it ? Comment #2 should have made that clear ;-)
Updated•17 years ago
|
Version: unspecified → Trunk
Comment 9•17 years ago
|
||
With this patch and the one on bug 383116 applied I get this error on startup: ###!!! ASSERTION: null ptr: 'aContainer != nsnull', file /mozilla/master/mozilla/rdf/base/src/nsRDFContainer.cpp, line 160 ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFContainer.Init]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: file:///mozilla/master/mozilla/sm/dist/bin/components/nsExtensionManager.js :: getContainer :: line 359" data: no] ************************************************************ Otherwise it seems to work fine. Could you also do a patch for getting "Get New Themes" working? - or file a follow up bug.
Comment 10•17 years ago
|
||
Comment on attachment 271417 [details] [diff] [review] Proposed patch r=me if you s/etBoolValue/etBoolPref/ before checkin. Also please file follow up patch/bug for the GetNewThemes option.
Attachment #271417 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 11•17 years ago
|
||
Fix checked in. To clarify, note that this fix does not work using debug builds for the first browser window unless you have previously opened the extension manager.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 12•17 years ago
|
||
(In reply to comment #9) > With this patch and the one on bug 383116 applied I get this error on startup: > > ###!!! ASSERTION: null ptr: 'aContainer != nsnull', file > /mozilla/master/mozilla/rdf/base/src/nsRDFContainer.cpp, line 160 > ************************************************************ > * Call to xpconnect wrapped JSObject produced this error: * > [Exception... "Component returned failure code: 0x80004003 > (NS_ERROR_INVALID_POINTER) [nsIRDFContainer.Init]" nsresult: "0x80004003 > (NS_ERROR_INVALID_POINTER)" location: "JS frame :: > file:///mozilla/master/mozilla/sm/dist/bin/components/nsExtensionManager.js :: > getContainer :: line 359" data: no] > ************************************************************ FWIW this went away when I applied the patch on bug 383116 rather than my own hand-altered version, so I guess I messed it up originally.
Assignee | ||
Comment 13•17 years ago
|
||
Filed bug 391130 on the Get New Themes menuitem.
Comment 14•17 years ago
|
||
with this landed, during startup I get the exceptions in comment 4 and I also see 5616 bytes leaked on bloatcycle.html. nye also sees the exceptions and 5640 bytes leaked. As a bonus, my view->apply themes menu only has "Get New Themes" and a separator.
Comment 15•17 years ago
|
||
ugh, I only see problems with a debug build (non-debug build has classic & modern in view->apply themes)
Assignee | ||
Comment 16•17 years ago
|
||
(In reply to comment #14) >with this landed, during startup I get the exceptions in comment 4 and I also >see 5616 bytes leaked on bloatcycle.html. nye also sees the exceptions and >5640 bytes leaked. We now load EM on startup, so if it leaks, then so do we. File a bug on EM? >As a bonus, my view->apply themes menu only has "Get New Themes" and a >separator. (In reply to comment #15) >ugh, I only see problems with a debug build (non-debug build has classic & >modern in view->apply themes) We know about that. See the references to bug 383116.
Comment 17•17 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/200708070303 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) V.Fixed: I'm not getting bug 384693 comment 4 exception anymore, and the 2 themes are there.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•