Closed
Bug 383099
Opened 17 years ago
Closed 17 years ago
error in Makefile creation caused by autoconf syntax
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wolfiR, Unassigned)
References
Details
Attachments
(2 files)
2.02 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
8.32 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
During makefile creation the following error appears: Unknown variable:toolkit/airbag/client/Makefile:98: sed -e "s/@APP_NAME@/$(MOZ_APP_DISPLAYNAME)/" $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | That's because the replacement algorithm searches for @STRING@ in makefiles to replace. The string should be bounded with a different character. Simple patch upcoming.
Reporter | ||
Comment 1•17 years ago
|
||
Reporter | ||
Updated•17 years ago
|
Attachment #267113 -
Flags: review?(ted.mielczarek)
Comment 2•17 years ago
|
||
It looks like Dave was just following the example set elsewhere in the tree: http://mxr.mozilla.org/mozilla/source/browser/app/Makefile.in#373 Does this same error show up in those Makefiles as well?
Reporter | ||
Comment 3•17 years ago
|
||
Yes: Unknown variable:browser/app/Makefile:328: sed -e "s/@APP_VERSION@/$(APP_VERSION)/" -e "s/@APP_NAME@/$(APP_NAME)/" $(srcdir)/macbuild/Contents/Info.plist.in > $(DIST)/$(APP_NAME).app/Contents/Info.plist I've noticed the issue in a xulrunner build and so I haven't noticed this.
Reporter | ||
Comment 4•17 years ago
|
||
This is not a severe error. I mean everything is working well besides of the error message but it should still be fixed ;-)
Comment 5•17 years ago
|
||
Comment on attachment 267113 [details] [diff] [review] patch Ok, r=me if you promise to at least file a followup to fix the rest of the tree.
Attachment #267113 -
Flags: review?(ted.mielczarek) → review+
Reporter | ||
Comment 6•17 years ago
|
||
Moving where more appropriate since to address the same issues over the tree
Component: Breakpad Integration → Build Config
Product: Toolkit → Core
QA Contact: breakpad.integration → build-config
Summary: error in Makefile creation caused by crashreporter Makefile.in → error in Makefile creation caused by autoconf syntax
Reporter | ||
Comment 7•17 years ago
|
||
one more: Unknown variable:mail/app/Makefile:298: sed -e "s/@APP_VERSION@/$(APP_VERSION)/" -e "s/@APP_NAME@/$(APP_NAME)/" $(srcdir)/macbuild/Contents/Info.plist.in > $(DIST)/$(APP_NAME).app/Contents/Info.plist
Reporter | ||
Comment 8•17 years ago
|
||
Patch that should fix the rest. (At least all I found)
Reporter | ||
Updated•17 years ago
|
Attachment #267139 -
Flags: review?(ted.mielczarek)
Comment 9•17 years ago
|
||
Comment on attachment 267139 [details] [diff] [review] patch #2 We're inconsistent about how we handle this in the tree, suite/app/Makefile.in does this particular thing using escaped @, but these same Makefiles use % to do some sed replacement in a shell script. I think the % is probably better, since that way we're not fooling anyone into thinking we're doing autoconf substitution.
Attachment #267139 -
Flags: review?(ted.mielczarek) → review+
Reporter | ||
Comment 10•17 years ago
|
||
Second patch checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•