340752 - Undefined variable error in Makefile

Status: VERIFIED FIXED

(Calendar :: Build Config, defect)

Description

[Matthew (lilmatt) Willis]

As a result of checkins from bug 334417 building Sunbird now gives the following error:

Unknown variable:calendar/sunbird/app/Makefile:293:     sed -e "s/@APP_VERSION@/$(APP_VERSION)/" -e "s/@APP_NAME@/$(APP_NAME)/" -e "s/@MAC_CREATOR_CODE@/$(MAC_CREATOR_CODE)/" $(srcdir)/macbuild/Contents/Info.plist.in > $(DIST)/$(APP_NAME).app/Contents/Info.plist

We need to define APP_VERSION in the makefile as SUNBIRD_VERSION

Comment 1

[Matthew (lilmatt) Willis]

Not going to make the 0.3 train.

Comment 2

[Matthew (lilmatt) Willis]

Nor 0.5

Comment 3

[ause]

the error still exists in 0.8pre but doesn't have too much impact. looks like the whole replacement line is no longer needed.
maybe someone with some understanding for mac OSX should comment on it...

Comment 4

[Phil Ringnalda (:philor)]

I'm not sure what error you are still seeing (the only one I see is a failure to find and copy shlibsign and mangle during the Intel half of the build), but it shouldn't be this, which was fixed by bug 334417. If you were still seeing this, then rather than right-click, Get Info on the app bundle showing "Sunbird 0.8pre © 1998-2008 Contributors" in the version field, it would probably be "Sunbird @APP_VERSION@ © 1998-2008 Contributors" (or worse, depend on how badly it was blowing up).

Comment 5

[ause]

i had a closer look now:
the error is caused by using autoconf-like variables for plaintext replacement. maybe someone intended to do the replacement in calendar/sunbird/app/macbuild/Contents/Info.plist.in as part of configure.
now there are these variable like strings left in Info.plist.in and Makefile.in and cause this error at configure time (btw., nothing is broken because of that...).
proposed fix to get rid of the error is to replace the according strings in Makefile.in and Info.plist.in
@SOME_VAR@ -> xxxSOME_VARxxx
or similar...

Comment 6

[Phil Ringnalda (:philor)]

Oh, bug 383099. Comment 0 threw me off, making it sound like sed was failing to replace (which it probably was, too, but isn't now).

Comment 7

[Martin Schröder [:mschroeder]]

Just a wild guess... but would a solution like in bug 414530 work?

Comment 8

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Oh, sort of approximately bug 414530, in that that's another bug where I said "you need to do the same thing as in bug 383099."

Comment 9

[Matthew (lilmatt) Willis]

Comment on attachment 318551 [details] [diff] [review]
Fix v.1

r=lilmatt

Comment 10

[Phil Ringnalda (:philor)]

calendar/sunbird/app/Makefile.in 1.60
calendar/sunbird/app/macbuild/Contents/Info.plist.in 1.14
calendar/sunbird/app/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in 1.4
calendar/sunbird/app/Makefile.in 1.21.2.23
calendar/sunbird/app/macbuild/Contents/Info.plist.in 1.5.2.9
calendar/sunbird/app/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in 1.1.2.4

Comment 11

[Stefan Sitter [:ssitter]]

Comparing the 2008-05-02-19 build log file <http://tinderbox.mozilla.org/showlog.cgi?log=Sunbird-Mozilla1.8/1209782640.1209785873.7706.gz&fulltext=1> with the 2008-05-04-19 build log file <http://tinderbox.mozilla.org/showlog.cgi?log=Sunbird-Mozilla1.8/1209954540.1209957746.12754.gz&fulltext=1> I can verify that the error is gone. But I can't verify that the correct values have been written to the builds due to the lack of a mac system.

Comment 12

[ause]

checked the replacements on the tinderbox. looks correct to me.